Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Time Out with {Failed} bulk downloading #710

Open
mayank-procogia opened this issue Nov 28, 2023 · 2 comments
Open

Session Time Out with {Failed} bulk downloading #710

mayank-procogia opened this issue Nov 28, 2023 · 2 comments

Comments

@mayank-procogia
Copy link

mayank-procogia commented Nov 28, 2023

When trying to download a large batch render (HTML) and download as a Zip of all the packages (300+) present on the shiny apps deployment (https://rinpharma.shinyapps.io/riskassessment/), the rendering takes almost 1 hour and the application auto logs off from the current session. There is no error that is generated for the auto log off. This behaviour is reproducible with Shiny apps, Azure VM, AWS VM and RS Connect.

Similar experience on local machine setup as well.

@AARON-CLARK
Copy link
Collaborator

AARON-CLARK commented Dec 4, 2023

I discussed with Mayank on a call 12/1, where I described that we don't envision users rendering / downloading that many reports at once because the app is mostly likely just supporting a "more official" qualification process within the org that produces official documentation for regulatory agencies. Thus, the app's highest and best use is for users to generate a report to include with their "GxP package inclusion request", submitted to the org's governing body for the GxP env. However, with that said, most orgs would likely require that all the package's imports / dependencies' risk also be assessed, so assessing 1 pkg could turn into 25 pkgs pretty quickly.

In any respect, if we allow users to download 1 or 30 or 300 pkgs, we don't want the app to render for such a long time (especially since the rest of the app is locked until that process is finished) and we certainly don't want the app to crash. Let's explore two things:

  1. Move the rendering/knitting process to another process. Related to Need for separate R processes #711
  2. For downloading >= 10 reports, add a modal that asks the user to confirm their selection, warning them that "Rendering X reports at once will take some time. Are you sure you want to continue?" or something similar.

@aclark02-arcus
Copy link
Collaborator

Will be closed when #731 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants