Feedback on the metric classes

[llrs-roche]

A couple of comments on the package and the metrics classes:

I think the example code on the README is not up to date, I couldn't find metrics() on the package and I didn't found a way to testing one or two metrics of a package.

I found the file classes_metrics.R a bit dense maybe extra comments would be good or splitting and extending each atomic classes on their own might make it easier to read. Also I'm not sure if we should accept raw and complex metrics data (classes included on classes_atomic). I guess they can be useful for storing data...

The help page of ?pkg_resource_policy has a very long use section. On other packages using S7 (ellmer for example) avoid this problem (as well as other help pages on this package). I'm not sure what causes this long class definition as I've never created documentation for S7 classes/methods.

[dgkf]

Hmm.. double check that you've built the latest version. It's exported in NAMESPACE

But full disclosure, I pushed up this code last night, so if you cloned when I first published it's very possible that things have changed since then!

I haven't even begun to think about documentation yet. For right now, functions are being constantly refactored as I explore the architecture design space. Thanks for the link for ellmer - I'll definitely look to some of the other packages that have mastered S7 documentation before I try to take a holistic pass at things.

[llrs-roche]

Sorry, I didn't realize it was updated recently. I'll check the package again soon with more time to see if I understand it well.

The comment about documentation is just for me to follow and understand (I don't expect a polished doc with examples and R CMD checks passing). Overall, I'm a bit impressed but how few lines do so much.