Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: derive_vars_dt() #2654

Open
Fanny-Gautier opened this issue Jan 31, 2025 · 2 comments
Open

Documentation: derive_vars_dt() #2654

Fanny-Gautier opened this issue Jan 31, 2025 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Fanny-Gautier
Copy link
Collaborator

Please select a category the issue is focused on?

Function Documentation

Let us know where something needs a refresh or put your idea here!

Could the error/warning message or the function's documentation be updated for the permitted values of date_imputation? Or further checks applied for the argument date_imputation?

When not "properly" used (e.g. "15" instead of "mid") the warning message is not very clear and the results are scary. Currently "15" seems permitted.

Image
Image

It's not visible when there is no partial date to impute, but as soon as there is data (which wasn't the case with previous data transfers) to impute, there's this weird message that the user needs to pay attention to and understand.

@Fanny-Gautier Fanny-Gautier added the documentation Improvements or additions to documentation label Jan 31, 2025
@bms63
Copy link
Collaborator

bms63 commented Jan 31, 2025

Probably should improve that error message and not have mutate() in it! @pharmaverse/admiral

I think we could apply a check on date_imputation for sure.

@bundfussr
Copy link
Collaborator

Yes, we should check the validity of date_imputation. Most likely the invalid date_imputation value causes the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

No branches or pull requests

4 participants