From 1345e31c45573e3e349ec4a9eeeb197b9d333f51 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adam=20Fory=C5=9B?= <adam.forys@gmail.com>
Date: Mon, 20 Nov 2023 14:48:43 +0100
Subject: [PATCH] Allow to use latest lintr cran release. (#169)

* Allow to use latest lintr cran release.

* Add install package locally step.

* Update lintr.yml

* Update lock_and_prop.Rmd

Fix admiraldev url.
---
 .github/workflows/lintr.yml | 31 +++++++++++++++++++++++++++++++
 vignettes/lock_and_prop.Rmd |  2 +-
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/lintr.yml b/.github/workflows/lintr.yml
index 7731bbfc..9ef028ad 100644
--- a/.github/workflows/lintr.yml
+++ b/.github/workflows/lintr.yml
@@ -15,6 +15,16 @@ on:
         default: 'false'
         required: false
         type: string
+      latest-lintr:
+        description: 'Latest lintr CRAN release'
+        default: 'false'
+        required: false
+        type: string
+      install-package:
+        description: 'Install package locally.'
+        default: 'false'
+        required: false
+        type: string
   workflow_call:
     inputs:
       r-version:
@@ -27,6 +37,16 @@ on:
         default: 'false'
         required: false
         type: string
+      latest-lintr:
+        description: 'Latest lintr CRAN release'
+        default: 'false'
+        required: false
+        type: string 
+      install-package:
+        description: 'Install package locally.'
+        default: 'false'
+        required: false
+        type: string 
 
 name: Lint
 
@@ -90,6 +110,17 @@ jobs:
           enable-check: false
         env:
           GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Install latest release of lintr
+        run: |
+          install.packages("lintr", repos = "https://packagemanager.posit.co/cran/latest/")
+        shell: Rscript {0}
+        if: ${{ inputs.latest-lintr == 'true' }}
+
+      - name: Install package
+        run: renv::install(".", dependencies = "no-deps")
+        shell: Rscript {0}
+        if: ${{ inputs.install-package == 'true' }}
       ##################### END boilerplate steps #####################
 
       - name: Changed files
diff --git a/vignettes/lock_and_prop.Rmd b/vignettes/lock_and_prop.Rmd
index 6dca810e..05de2c8d 100644
--- a/vignettes/lock_and_prop.Rmd
+++ b/vignettes/lock_and_prop.Rmd
@@ -28,7 +28,7 @@ The intention of the `renv.lock` file is to create a harmonized development envi
 
 Unfortunately, this adoption of a `renv.lock` file also creates a few barriers for our development process.  First, if we **lock** in a version of R and R packages then we can not quickly adopt the latest and greatest of updates from new releases.  Second, how does a team decide to update a certain package or version of R and who gets to make that final call? Finally, when do we make updates to the lock file. Hopefully, the below will provide some guidance around these issues.  Please note, these process might change over time and admiral developers are encouraged to stay up to date with the latest processes and participate in the discussion.
 
-**Note:** Through GitHub Actions we continuously test admiral's integration with the latest 3 snapshots of dependent R packages on CRAN that are closest in date to latest 3 versions of R.  Please see [GitHub Actions/Workflows]( https://pharmaverse.github.io/admiraldev/devel/articles/pr_review_guidance.html#github-actionsworkflows) on the `{admiraldev}` site for more information on this process.
+**Note:** Through GitHub Actions we continuously test admiral's integration with the latest 3 snapshots of dependent R packages on CRAN that are closest in date to latest 3 versions of R.  Please see [GitHub Actions/Workflows]( https://pharmaverse.github.io/admiraldev/articles/pr_review_guidance.html#github-actionsworkflows) on the `{admiraldev}` site for more information on this process.
 
 ### R Package Updates and Lock Files