Skip to content

Commit d6bb8b4

Browse files
plantecplantec
committed
ToSpaceSkinPhasesManagerTest
1 parent ca704c8 commit d6bb8b4

File tree

3 files changed

+204
-14
lines changed

3 files changed

+204
-14
lines changed

‎src/Toplo-Tests/ToSpaceSkinPhasesManagerTest.class.st

Lines changed: 199 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,20 @@ ToSpaceSkinPhasesManagerTest >> testCheckSkinPhasesIn [
3939
" since space is not opened, the skin phases installation should be postponed "
4040
self assert: space skinPhasesManager isSkinPhasesInstallationPostponed.
4141
space allowSkinPhases: false.
42+
space skinPhasesManager startSkinPhasesIn: space.
4243
self deny: space skinPhasesManager isSkinPhasesInstallationPostponed.
43-
space show.
44-
space when: BlSpaceShownEvent do: [ :event | | theSpace |
45-
theSpace := event currentTarget.
46-
theSpace checkSkinPhases.
47-
" since skin phases are not allowed "
48-
self deny: theSpace skinPhasesManager skinPhasesInstalled.
49-
" now allow skin phases "
50-
theSpace allowSkinPhases: true.
51-
" since skin phases are allowed and the space is opened "
52-
self assert: theSpace skinPhasesManager skinPhasesInstalled ].
53-
44+
self deny: space skinPhasesManager skinPhasesInstalled.
5445

55-
56-
46+
space checkSkinPhases.
47+
" since skin phases are not allowed "
48+
self deny: space skinPhasesManager skinPhasesInstalled.
49+
" now allow skin phases "
50+
space allowSkinPhases: true.
51+
self assert: space skinPhasesManager isSkinPhasesInstallationPostponed.
52+
space skinPhasesManager startSkinPhasesIn: space.
53+
" since skin phases are allowed and the space is opened "
54+
self deny: space skinPhasesManager isSkinPhasesInstallationPostponed.
55+
self assert: space skinPhasesManager skinPhasesInstalled
5756
]
5857

5958
{ #category : 'tests' }
@@ -65,3 +64,190 @@ ToSpaceSkinPhasesManagerTest >> testInitialize [
6564
self deny: m isSkinPhasesInstallationPostponed.
6665
self assert: m allowSkinPhases
6766
]
67+
68+
{ #category : 'tests' }
69+
ToSpaceSkinPhasesManagerTest >> testInstalledSkinInstallerPhaseIn [
70+
71+
space skinPhasesManager startSkinPhasesIn: space.
72+
self assert: ((space skinPhasesManager installedSkinInstallerPhaseIn: space) isKindOf: ToSpaceSkinInstallerPhase).
73+
74+
75+
]
76+
77+
{ #category : 'tests' }
78+
ToSpaceSkinPhasesManagerTest >> testInstalledSkinStatePhaseIn [
79+
80+
space skinPhasesManager startSkinPhasesIn: space.
81+
self assert: ((space skinPhasesManager installedSkinStatePhaseIn: space) isKindOf: ToSpaceSkinStatePhase).
82+
]
83+
84+
{ #category : 'tests' }
85+
ToSpaceSkinPhasesManagerTest >> testIsSkinInstallerPhaseInstalledIn [
86+
87+
space checkSkinPhases.
88+
" since space is not opened, the skin phases installation should be postponed "
89+
self deny: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space).
90+
space skinPhasesManager startSkinPhasesIn: space.
91+
self assert: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space).
92+
93+
]
94+
95+
{ #category : 'tests' }
96+
ToSpaceSkinPhasesManagerTest >> testIsSkinPhasesInstallationPostponed [
97+
98+
space checkSkinPhases.
99+
" since space is not opened, the skin phases installation should be postponed "
100+
self assert: (space skinPhasesManager isSkinPhasesInstallationPostponed).
101+
space skinPhasesManager startSkinPhasesIn: space.
102+
self deny: (space skinPhasesManager isSkinPhasesInstallationPostponed).
103+
104+
105+
106+
]
107+
108+
{ #category : 'tests' }
109+
ToSpaceSkinPhasesManagerTest >> testIsSkinStatePhaseInstalledIn [
110+
111+
space checkSkinPhases.
112+
" since space is not opened, the skin phases installation should be postponed "
113+
self deny: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
114+
space skinPhasesManager startSkinPhasesIn: space.
115+
self assert: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
116+
117+
]
118+
119+
{ #category : 'tests' }
120+
ToSpaceSkinPhasesManagerTest >> testOnInstalledIn [
121+
122+
space checkSkinPhases.
123+
" since space is not opened, the skin phases installation should be postponed "
124+
self assert: space skinPhasesManager isSkinPhasesInstallationPostponed.
125+
space skinPhasesManager stopSkinPhasesIn: space.
126+
" here nothing is installed nor postponed"
127+
space skinPhasesManager onInstalledIn: space.
128+
" since space is not opened, the skin phases installation should be postponed "
129+
self assert: space skinPhasesManager isSkinPhasesInstallationPostponed
130+
]
131+
132+
{ #category : 'tests' }
133+
ToSpaceSkinPhasesManagerTest >> testOnInstalledIn2 [
134+
135+
space skinPhasesManager startSkinPhasesIn: space.
136+
" directly install (bypass the space opened/closed checking) "
137+
self deny: space skinPhasesManager isSkinPhasesInstallationPostponed.
138+
space skinPhasesManager stopSkinPhasesIn: space.
139+
" here nothing is installed nor postponed"
140+
space skinPhasesManager onInstalledIn: space.
141+
self deny: space skinPhasesManager skinPhasesInstalled.
142+
" since space is not opened, the skin phases installation should be postponed "
143+
self assert: space skinPhasesManager isSkinPhasesInstallationPostponed
144+
]
145+
146+
{ #category : 'tests' }
147+
ToSpaceSkinPhasesManagerTest >> testOnUninstalledIn [
148+
149+
space checkSkinPhases.
150+
" since space is not opened, the skin phases installation should be postponed "
151+
self assert: space skinPhasesManager isSkinPhasesInstallationPostponed.
152+
space skinPhasesManager onUninstalledIn: space.
153+
" here nothing is installed nor postponed"
154+
self deny: space skinPhasesManager isSkinPhasesInstallationPostponed.
155+
self deny: space skinPhasesManager skinPhasesInstalled
156+
]
157+
158+
{ #category : 'tests' }
159+
ToSpaceSkinPhasesManagerTest >> testPostponeStartSkinPhasesIn [
160+
161+
space checkSkinPhases.
162+
space skinPhasesManager onUninstalledIn: space.
163+
" here nothing is installed nor postponed"
164+
space skinPhasesManager postponeStartSkinPhasesIn: space.
165+
self assert: space skinPhasesManager isSkinPhasesInstallationPostponed
166+
]
167+
168+
{ #category : 'tests' }
169+
ToSpaceSkinPhasesManagerTest >> testSkinPhasesInstalled [
170+
171+
space checkSkinPhases.
172+
" since space is not opened, the skin phases installation should be postponed "
173+
self deny: (space skinPhasesManager skinPhasesInstalled).
174+
space skinPhasesManager startSkinPhasesIn: space.
175+
self assert: (space skinPhasesManager skinPhasesInstalled).
176+
177+
]
178+
179+
{ #category : 'tests' }
180+
ToSpaceSkinPhasesManagerTest >> testStartSkinInstallerPhaseIn [
181+
182+
space checkSkinPhases.
183+
space skinPhasesManager onUninstalledIn: space.
184+
" here nothing is installed nor postponed"
185+
space skinPhasesManager startSkinInstallerPhaseIn: space.
186+
self assert: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space)
187+
]
188+
189+
{ #category : 'tests' }
190+
ToSpaceSkinPhasesManagerTest >> testStartSkinPhasesIn [
191+
192+
space checkSkinPhases.
193+
" since space is not opened, the skin phases installation should be postponed "
194+
self deny: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
195+
space skinPhasesManager startSkinPhasesIn: space.
196+
self assert: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space).
197+
self assert: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
198+
199+
]
200+
201+
{ #category : 'tests' }
202+
ToSpaceSkinPhasesManagerTest >> testStartSkinStatePhaseIn [
203+
204+
space checkSkinPhases.
205+
space skinPhasesManager onUninstalledIn: space.
206+
" here nothing is installed nor postponed"
207+
space skinPhasesManager startSkinStatePhaseIn: space.
208+
self assert: (space skinPhasesManager isSkinStatePhaseInstalledIn: space)
209+
]
210+
211+
{ #category : 'tests' }
212+
ToSpaceSkinPhasesManagerTest >> testStopSkinInstallerPhaseIn [
213+
214+
space checkSkinPhases.
215+
space skinPhasesManager onUninstalledIn: space.
216+
" here nothing is installed nor postponed"
217+
space skinPhasesManager startSkinInstallerPhaseIn: space.
218+
self assert: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space).
219+
space skinPhasesManager stopSkinInstallerPhaseIn: space.
220+
self deny: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space).
221+
222+
]
223+
224+
{ #category : 'tests' }
225+
ToSpaceSkinPhasesManagerTest >> testStopSkinPhasesIn [
226+
227+
space checkSkinPhases.
228+
" since space is not opened, the skin phases installation should be postponed "
229+
self deny: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
230+
space skinPhasesManager startSkinPhasesIn: space.
231+
self assert: space skinPhasesManager skinPhasesInstalled.
232+
self assert: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space).
233+
self assert: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
234+
space skinPhasesManager stopSkinPhasesIn: space.
235+
self deny: space skinPhasesManager skinPhasesInstalled.
236+
self deny: (space skinPhasesManager isSkinInstallerPhaseInstalledIn: space).
237+
self deny: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
238+
239+
240+
241+
]
242+
243+
{ #category : 'tests' }
244+
ToSpaceSkinPhasesManagerTest >> testStopSkinStatePhaseIn [
245+
246+
space checkSkinPhases.
247+
space skinPhasesManager onUninstalledIn: space.
248+
" here nothing is installed nor postponed"
249+
space skinPhasesManager startSkinStatePhaseIn: space.
250+
self assert: (space skinPhasesManager isSkinStatePhaseInstalledIn: space).
251+
space skinPhasesManager stopSkinStatePhaseIn: space.
252+
self deny: (space skinPhasesManager isSkinStatePhaseInstalledIn: space)
253+
]

‎src/Toplo-Tests/ToSpaceSkinStatePhaseTest.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ ToSpaceSkinStatePhaseTest >> testStartSkinPhases [
3737
p isKindOf: ToSpaceSkinStatePhase ]).
3838
space close ].
3939

40-
space skinPhasesManager onInstalledIn: space
40+
space skinPhasesManager startSkinPhasesIn: space
4141

4242

4343
]

‎src/Toplo/ToSpaceSkinPhasesManager.class.st

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,10 @@ ToSpaceSkinPhasesManager >> startSkinInstallerPhaseIn: aSpace [
139139
ToSpaceSkinPhasesManager >> startSkinPhasesIn: aSpace [
140140

141141
self skinPhasesInstalled ifTrue: [ ^ self ].
142+
self allowSkinPhases ifFalse: [ ^ self ].
143+
self isSkinPhasesInstallationPostponed ifTrue: [
144+
aSpace removeEventHandler: spaceShownEventHandler.
145+
spaceShownEventHandler := nil. ].
142146
self
143147
startSkinInstallerPhaseIn: aSpace;
144148
startSkinStatePhaseIn: aSpace.

0 commit comments

Comments
 (0)