You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you run rig project expecting to see your project scripts, but they are not there, there is no warning or verbose message that the config file could not be found.
We do not want such a message on rig commands in general, but when running rig project or rig project help, not having it could lead to troubleshooting confusion.
The text was updated successfully, but these errors were encountered:
There is already code that should be able to output such a warning. The problem is that cli/commands/project_config.go is re-initializing a Logger in NewProjectConfigFromFile() rather than leveraging the centrally instantiated Logger instance. As such, verbose output is sticking with the default behavior of being hidden.
We can fix this by using LoggerInit() again to create a fully-functional Logger instance, but that would require passthru of the verbose flag, which seems just as involved as passing the main logger instance.
However, passing the primary output mechanism around in function calls seems like poor form in how to leverage a "support library" such as project_config, maybe we should go back to the abortive attempt to return the error and have the caller decide what to do with it?
If you run
rig project
expecting to see your project scripts, but they are not there, there is no warning or verbose message that the config file could not be found.We do not want such a message on rig commands in general, but when running rig project or rig project help, not having it could lead to troubleshooting confusion.
The text was updated successfully, but these errors were encountered: