Excel file doesn't import properly anymore?

[vvdbos]

Hi, I've been using CharAnalysis in MatLab. Today (20210409) the parameters were read wrong, though last November/December 2020 it worked fine. Maybe a MatLab update changed how excel files are read? I have very little experience with MatLab sorry. I got the script to work again by changing the row index for each parameter in the CharParameters script (rows 16 to 30), though I feel like there is probably a better way to fix this?

Thanks!

[phiguera]

Hi -- I need a bit more info. to be able to help or chime in here, e.g., like an error message, or what was "read wrong." Thanks.

[vvdbos]

Sorry, I'm new to github, so still learning. :)

To clarify, I am using the excel template (templateChar.xls) and trying to run through Matlab. I only inserted my data and zone boundaries and used all default parameters.

This is the initial error I got:

Error using xlsread (line 257)
Unable to read sheet 'charParams'.
Requested sheet: 'charParams' not found.


Error in CharParameters (line 15)
    charParams = xlsread(fileName,'charParams','c2:c26');

Error in CharAnalysis (line 63)
    Results, site] = CharParameters(fileName);

Then I had a look through the CharParameters.m script and saw there is a discrepancy between the tab xlsread is looking for (i.e. 'charParams') and the actual tab name in the template (i.e. 'CharParams'). So I changed the tab name in the template (changing the capital 'C' to small 'c') and ran it again. That caused a different error:

Error using CharAnalysis (line 74)
Threshold values must be < 1.0 when using data-defined thresholds.
Change input parameters.

Of course the default threshold values are all < 1.0, so reading the script again, I figured out that the wrong charParams index is assigned to each internal parameter. So I changed the script to this (changing each index) and then it worked:

if min(fileName(end-2:end) == ['xls']) > 0  % If using an .xls file...
    charData = xlsread(fileName,'charData');
      
    charParams = xlsread(fileName,'charParams','c2:c26');
    Pretreatment.zoneDiv = charParams(1:9);
        Pretreatment.zoneDiv(isnan(Pretreatment.zoneDiv)) = [];    
    Pretreatment.yrInterp = charParams(10);
    Pretreatment.transform = charParams(11);
    Smoothing.method = charParams(12);
    Smoothing.yr = charParams(13);
    PeakAnalysis.cPeak = charParams(14);
    PeakAnalysis.threshType = charParams(15);
    PeakAnalysis.threshMethod = charParams(16);
    PeakAnalysis.threshValues = charParams(17:20);
    PeakAnalysis.minCountP = charParams(21);
    PeakAnalysis.peakFrequ = charParams(22);
    PeakAnalysis.bkgSens = charParams(23);
    Results.save = charParams(25);
    Results.saveFigures = charParams(24);
    if length(charParams) == 25
        Results.allFigures = charParams(25);
    else
        Results.allFigures = 1;
    end

I hope that makes sense. I have screenshots if you need them.

Thanks!