Remove Unstable Immutable.js API (#17)

This PR removes the unused and unstable Immutable.js helper API. I don't think it works great and I'd rather discourage this pattern.

Author: philipp-spiess

__tests__/ReComponentImmutable-test.js

@@ -18,7 +18,6 @@
     "babel-preset-env": "^1.7.0",
     "babel-preset-react": "^6.24.1",
     "flow-bin": "^0.82.0",
-    "immutable": "^3.8.2",
     "jest": "^23.6.0",
     "microbundle": "^0.6.0",
     "prettier": "^1.14.3",

package.json

@@ -22,11 +22,7 @@ export function Re(Component) {
         }
       }
 
-      // We might overwrite setState later for the Immutable.js helpers, thus we
-      // keep a reference to the original method around as well.
-      const originalSetState = this.setState;
       let setState = this.setState;
-
       if (process.env.NODE_ENV !== "production") {
         this.setState = () => {
           const name = this.displayName || this.constructor.name;
@@ -38,39 +34,6 @@ export function Re(Component) {
         };
       }
 
-      // We allow a hidden `Component#unstable_initialImmutableState` option to
-      // initialize the component state based on a returned Immutable.js record
-      // type.
-      //
-      // To manage the state, we define a couple of helper methods to make it
-      // work as a regular Component state must always be a plain JavaScript
-      // object.
-      //
-      // To emulate an Immutable.js object, we use a JavaScript object
-      // consisting of only one key: `immutableState`. To make the render method
-      // easier, we also expose `Component#immutableState` to access the
-      // components state since we don't want to overwrite `Component#state`.
-      //
-      // Note that this is unstable API and should not be used.
-      if (typeof this.unstable_initialImmutableState === "function") {
-        this.state = {
-          immutableState: this.unstable_initialImmutableState(props)
-        };
-
-        setState = (updater, callback) => {
-          originalSetState.call(
-            this,
-            (state, props) => ({
-              immutableState: updater(state.immutableState, props)
-            }),
-            callback
-          );
-        };
-        Object.defineProperty(this, "unstable_immutableState", {
-          get: () => this.state.immutableState
-        });
-      }
-
       // Sends an `action` to the reducer. The `reducer` must handle this action
       // and return either `NoUpdate()`, `Update(state)`, `SideEffects(fn)`, or
       // `UpdateWithSideEffects(state, fn)`.

src/re.js

@@ -40,10 +40,6 @@ declare export class ReComponent<
 
   send(action: Action): void;
   createSender<A: Action>(actionType: $ElementType<A, "type">): mixed => A;
-
-  // This type is only used when initialState returns an Immutable.js data type.
-  // Consider this API unstable.
-  +unstable_immutableState: $ElementType<State, "immutableState">;
 }
 
 declare export class RePureComponent<

type-definitions/ReComponent.js.flow

@@ -2048,10 +2048,6 @@ ignore-walk@^3.0.1:
   dependencies:
     minimatch "^3.0.4"
 
-immutable@^3.8.2:
-  version "3.8.2"
-  resolved "https://registry.yarnpkg.com/immutable/-/immutable-3.8.2.tgz#c2439951455bb39913daf281376f1530e104adf3"
-
 import-cwd@^2.1.0:
   version "2.1.0"
   resolved "https://registry.yarnpkg.com/import-cwd/-/import-cwd-2.1.0.tgz#aa6cf36e722761285cb371ec6519f53e2435b0a9"