Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command incompatible with current file type #210

Open
Essoje opened this issue Nov 25, 2021 · 1 comment
Open

Command incompatible with current file type #210

Essoje opened this issue Nov 25, 2021 · 1 comment

Comments

@Essoje
Copy link

Essoje commented Nov 25, 2021

Attempting to use command() or numeric_command(1) while viewing an image from inside an archive like a zip will result in this message. If this is the expected behavior, please consider changing it; if it's not, please fix this.
I'm sure it's obvious, but being able to use external commands is quite valuable. Sometimes I need to open the specific subfolder where the current image resides and it works with images, but I'm unable to use this on archives because of this behavior.

@phillipberndt
Copy link
Owner

The reason for this behavior is that there's no obvious way to pass the offset into the image container to the command. I guess we could introduce a few extra variables to extend the behavior, e.g. $file is substituted with the container, $offset with the offset into the container, $display_filename with the name displayed to the user, etc., and then only display the error if a user doesn't make use of any of these variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants