Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive_cbx.c incorrectly assumes only JPEG/PNG files #243

Open
ratinoxone opened this issue Aug 4, 2024 · 2 comments
Open

archive_cbx.c incorrectly assumes only JPEG/PNG files #243

ratinoxone opened this issue Aug 4, 2024 · 2 comments

Comments

@ratinoxone
Copy link

ratinoxone commented Aug 4, 2024

archive_cbx.c:

* Such files are guaranteed to contain _only_ jpg/png files, which allows
* to handle them directly using a gdkpixbuf.

This is not guaranteed. There are no formal specifications for cbX files. While JPEG and PNG are the most common formats, GIF and BMP files are not excluded. Disabling the archive_cbx backend is a workaround for this.

Edit: disabling the backend is a workaround for animated GIFs not playing.

@phillipberndt
Copy link
Owner

Thanks! These formats are also supported by GdkPixbuf. Did you see an archive with a format that is not in the wild?

@ratinoxone
Copy link
Author

Only one with a single animated GIF in the archive which would not play when the archive was named *.cbz. Disabling the backend is a workaround for this (I updated the first comment with this information).

I do not have the archive any more but I will see if I can find it again. It was a one-off thing, so I don't know that any code changes or fixes are required to accommodate it when disabling the backend for this one file worked. Maybe just a note in the man page for anyone else who stumbles across this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants