Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large messages would yield invalid JSON #1

Open
webOS101 opened this issue Sep 17, 2019 · 1 comment
Open

Large messages would yield invalid JSON #1

webOS101 opened this issue Sep 17, 2019 · 1 comment

Comments

@webOS101
Copy link

Because the forwarding code does not check for end of data, it's possible that a large message from gitter could be chunked into more than one chunk, causing an exception when attempting to parse the partial message.

@phillipuniverse
Copy link
Owner

@webOS101 thanks for the report, sorry this languished for so long. Do you have an example message that failed? This will be a good use case to add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants