Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armv8m: Add MCX N94x target #337

Merged
merged 2 commits into from
Aug 2, 2024
Merged

armv8m: Add MCX N94x target #337

merged 2 commits into from
Aug 2, 2024

Conversation

agkaminski
Copy link
Member

@agkaminski agkaminski commented Jul 26, 2024

JIRA: RTOS-881

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (mcxn94x).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

devices/uart-mcxn94x/uart.c Show resolved Hide resolved
devices/uart-mcxn94x/uart.c Outdated Show resolved Hide resolved
hal/armv8m/mcx/n94x/console.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/timer.c Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Outdated Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Outdated Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 26, 2024

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   38m 55s ⏱️ + 1m 11s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit fde217d. ± Comparison against base commit 8bead60.

♻️ This comment has been updated with latest results.

@agkaminski agkaminski force-pushed the agkaminski/n94x branch 2 times, most recently from e0f4b4f to 25abdb6 Compare July 26, 2024 13:46
devices/flash-mcxn94x/flash.c Outdated Show resolved Hide resolved
devices/flash-mcxn94x/flash.c Outdated Show resolved Hide resolved
devices/flash-mcxn94x/flash.c Outdated Show resolved Hide resolved
devices/flash-mcxn94x/flash.c Outdated Show resolved Hide resolved
devices/flash-mcxn94x/flash.c Outdated Show resolved Hide resolved
hal/armv8m/mcx/n94x/config.h Outdated Show resolved Hide resolved
hal/armv8m/mcx/Makefile Outdated Show resolved Hide resolved
hal/armv8m/mcx/hal.c Outdated Show resolved Hide resolved
hal/armv8m/Makefile Outdated Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.h Outdated Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Outdated Show resolved Hide resolved
hal/armv8m/mcx/n94x/n94x.c Outdated Show resolved Hide resolved
lukileczo
lukileczo previously approved these changes Jul 29, 2024
Copy link
Member

@lukileczo lukileczo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agkaminski
Copy link
Member Author

Setting to draft for now, PLL does not work yet

hal/armv8m/mcx/n94x/n94x.c Outdated Show resolved Hide resolved
@agkaminski agkaminski force-pushed the agkaminski/n94x branch 2 times, most recently from 62a83e8 to 8b12072 Compare August 2, 2024 13:31
hal/armv8m/mcx/n94x/n94x.c Outdated Show resolved Hide resolved
@agkaminski agkaminski marked this pull request as ready for review August 2, 2024 14:18
@agkaminski agkaminski merged commit 0264cc9 into master Aug 2, 2024
29 of 30 checks passed
@agkaminski agkaminski deleted the agkaminski/n94x branch August 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants