Skip to content

portal handling for phx-click-away #4141

@ssbb

Description

@ssbb

Environment

  • Elixir version (please paste the output of elixir -v):
Erlang/OTP 28 [erts-16.1.1] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]

Elixir 1.19.2 (compiled with Erlang/OTP 28)

  • Phoenix and LiveView versions (mix deps | grep -w 'phoenix\|phoenix_live_view'):
* phoenix 1.8.3 (Hex package) (mix)
  locked at 1.8.3 (phoenix) 36169f95
* phoenix_live_view 1.1.22 (Hex package) (mix)
  locked at 1.1.22 (phoenix_live_view) e1395d56

  • Operating system:
  • Windows
  • MacOS
  • Linux
  • Other (please specify):

Description

Right now phx-click-away checking via plain el.contains(clickStartedAt) but I am wondering if it would make sense to handle portals here? So first we check if clickStartedAt is within portal and if yes then check for it's associated template rather than element itself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions