Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for /photos/list.json API and include takenBefore and takenAfter parameters #1551

Open
emanchado opened this issue Sep 17, 2014 · 3 comments

Comments

@emanchado
Copy link

It would be very useful to be able to filter by "date taken" (and maybe "date uploaded") in the API, a la Flickr: https://www.flickr.com/services/api/flickr.photos.search.html.

Among other things, it would allow applications that collect "photographic memories" (like my own https://github.com/emanchado/clj-flickr-memories) to work with Trovebox. This is about the only thing I use Flickr for so I'm looking forward to finally be able to ditch Flickr and use only Trovebox.

I can give it a shot at trying to implement it, but I'd like to know if you would be interested in the patch.

@emanchado
Copy link
Author

Oops, I just realised by looking at the code that it's indeed possible (for the record, it's the parameters takenBefore and takenAfter). I'll leave this ticket open as you should update the documentation...

@jmathai
Copy link
Member

jmathai commented Sep 19, 2014

@emanchado Glad you found it. I'm updating the title to reflect that this is an issue to update documentation. By the way this works the same through the web UI also as do any other API parameters.

@jmathai jmathai changed the title Allow filtering by "date taken" in the API Update documentation for /photos/list.json API and include takenBefore and takenAfter parameters Sep 19, 2014
@emanchado
Copy link
Author

Thanks! BTW, take into account that it's not only takenBefore and takenAfter, but a whole lot of other parameters, too!

And it would be nice to document what formats are accepted (I found at least one parameter that didn't specify it and it wasn't clear at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants