Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

Test on PHP 8 #41

Open
GrahamCampbell opened this issue Jul 6, 2020 · 2 comments
Open

Test on PHP 8 #41

GrahamCampbell opened this issue Jul 6, 2020 · 2 comments

Comments

@GrahamCampbell
Copy link

There is no upper bound on the PHP version (and too late to add one in 1.x). We should test on PHP 8.0 with the CI.

@dbu
Copy link
Contributor

dbu commented Jul 6, 2020

i wonder if we don't want to add the upper bound anyways. then at least in the future, we are more robust.

@GrahamCampbell
Copy link
Author

An upperbound would be a good idea, because almost certainly PHP 9 will have totally deleted the concept of a resource, so things like https://github.com/php-http/message-factory/blob/master/src/StreamFactory.php#L17 need updating with whatever the replacement for fopen's return type is, and related types.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants