-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a way to access the provider original response #6
Comments
I'm not sure about it. In my opinion, it is not necessary to receive an original response from the provider. I have worked with payment gateways for over 20 years and have never encountered this situation. On the other hand, all input and output are logged throughout the entire package methods for debugging and tracking cases. |
Storing this type of information is seems unnecessary. |
As I said I have logged everything including incoming and outgoing parameters. It's enough for every kind of debugging. by the way feel free to add any required log in any step... |
I understand that but this isn't meant for debugging purposes but rather to supporting scenarios. |
As I said some responses are logging via my other (dependency) package laravel-xlog with a lots of useful information. So you can find the corresponding log and give them the actual response. |
Sometimes, we need access to the original response from a provider. To address this, it would be beneficial to implement something like a Response Object.
Instead of returning just a token or a bool value, we could create structured objects (e.g., VerifyResponse) that include:
Each provider would then be responsible for creating and returning this type of response object.
However, implementing this would introduce breaking changes to existing integrations. We would need to carefully consider this impact or release it as part of a new version to ensure backward compatibility.
The text was updated successfully, but these errors were encountered: