Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling getSerializableData() #81

Open
cebe opened this issue Feb 7, 2025 · 1 comment · May be fixed by #98
Open

Avoid calling getSerializableData() #81

cebe opened this issue Feb 7, 2025 · 1 comment · May be fixed by #98
Assignees

Comments

@cebe
Copy link
Member

cebe commented Feb 7, 2025

moved from cebe#123

cebe#112 (comment)

Calling getSerializableData() is a significant performance overhead which is currently necessary because of how php-openapi handles default values. We should try to avoid that.

@cebe cebe added under discussion Still discussing, not ready for implementation. and removed under discussion Still discussing, not ready for implementation. labels Feb 7, 2025
@SOHELAHMED7 SOHELAHMED7 self-assigned this Mar 8, 2025
@SOHELAHMED7 SOHELAHMED7 changed the title Avoid calling getSerializableData() Avoid calling getSerializableData() Mar 10, 2025
@SOHELAHMED7 SOHELAHMED7 linked a pull request Mar 10, 2025 that will close this issue
@SOHELAHMED7 SOHELAHMED7 linked a pull request Mar 10, 2025 that will close this issue
@SOHELAHMED7
Copy link
Member

In order to fix this issue

The method getSerializableData() is used in resolving property and faker. For resolving properties, I am changing the implementation as per spec: default value of nullable is false.

As per current implementation

Pull request #98 will

  • fix this incorrect behaviour
  • make this lib more OpenAPI spec compliant
  • get rid of getSerializableData() in resolving properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants