Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IFunction constructor #14

Closed
gregor-j opened this issue Aug 7, 2024 · 0 comments · Fixed by #15
Closed

Remove IFunction constructor #14

gregor-j opened this issue Aug 7, 2024 · 0 comments · Fixed by #15
Assignees
@gregor-j

Comments

@gregor-j
Copy link
Contributor

gregor-j commented Aug 7, 2024

The common constructor for all interfaces is defined in ISerializable. The interface IFunction overwrites this constructor needlessly. Remove the constructor from IFunction.
@gregor-j gregor-j self-assigned this Aug 7, 2024
gregor-j added a commit that referenced this issue Aug 7, 2024
@gregor-j
Remove the constructor from IFunction #14
0c817d1
@gregor-j gregor-j linked a pull request Aug 7, 2024 that will close this issue
Remove the constructor from IFunction #15
Merged
gregor-j added a commit that referenced this issue Aug 7, 2024
@gregor-j
Remove the constructor from IFunction #14
35aa3e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregor-j gregor-j

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the constructor from IFunction php-sap/interfaces
1 participant
@gregor-j