Skip to content

Conversation

@devnexen
Copy link
Member

@devnexen devnexen commented Dec 2, 2025

the timeout needed to be unsigned.

the timeout needed to be unsigned.
Copy link
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ain't enough I think.

#define PHP_TIMEOUT_ULL_MAX UINT64_MAX

This is defined as a 64-bit number. You'll have to either use a uint64_t or a double to compare. Probably the former. (which btw means that the check won't do anything on 32-bits)

@devnexen
Copy link
Member Author

devnexen commented Dec 2, 2025

ah yes zend_ulong is uint32_t in 32 bits case..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants