Fix the conversion of lists to strings #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
approved these changes
Nov 28, 2025
Member
|
Thanks for this improvement! |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Nov 29, 2025
…tting types from docblocks (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [PropertyInfo] treat `mixed[]` the same as `array` when getting types from docblocks | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | account for phpDocumentor/TypeResolver#237 | License | MIT This fixes the PropertyInfo component tests by treating `mixed[]` as an alias of `array` sticking with the current behaviour even if that may technically not be fully correct to avoid unwanted behaviour changes for existing applications (see #62546 (comment)). Commits ------- 2d94451 treat `mixed[]` the same as `array` when getting types from docblocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This topic has already been discussed here: #48
I believe that we need to slightly modify the logic for converting lists to strings.
For example,
mixed[]is not the same asarray. If we explicitly writemixed, it means that any value can be included. If we simply usearray, it means that we have not explicitly specified what can be included in the array.Static analyzers in particular distinguish between these cases. I suggest that we also distinguish between these cases here.