Skip to content

Conversation

@mspirkov
Copy link
Contributor

If I understand everything correctly, it should look something like this :)
I suggest adding a Value Object for the template type in a separate request.

Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, this is a very nice start.I think we are nearly there. Some small suggestions regarding naming and typing. And one bigger concern.

For example self<TValue>. The value between the <> can be resolved, but when it is a Object we should translate it to a new type, GenericTemplate as we can not know for sure whether TValue is a class in the current namespace or a template value. TemplateValue will be a new Type so it will fit into your current implementation. Maybe we can pass the FQEN that we resolved in the construction of the Generic like you do now. So we can expose this information to our users in a method like getResolvedType?

This way we never do false assumptions. But still provide all info we have

@mspirkov
Copy link
Contributor Author

Thanks for your valuable comments. Then I will implement the template type here. I like your idea.

@mspirkov
Copy link
Contributor Author

It seems to be looking good now. Please take a look :)

@jaapio jaapio changed the base branch from 1.x to 2.x November 29, 2025 09:33
@jaapio
Copy link
Member

jaapio commented Nov 29, 2025

Awesome! Thanks for this.

I changed the target branch to the new 2.x branch. This is good to be merged. It will take some time to have v2 ready as I want to remove some old legacy from the code base.

@jaapio jaapio merged commit 9049757 into phpDocumentor:2.x Nov 29, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants