Remove/phpstan v1 parser #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
remove/phpstan-v1-parser
branch
from
21edc53 to
47ee8c5
Compare
phpstan v1 parser is old and not longer supported.
Compound types containg `?` nullables are deprecated in php, and not supported by phpstan. In v1 we had a work around for this but this was slow and fragile. The nullable format has been deprecated since 2023 and is now removed. We still produce a deprecation error to warn people about invalid type handling. fixes #184
The rest of the eco system is moving forward, so we can drop php 7.3 now. The number of installations is really low on 7.3. For the 7.3 people we can still have v1.x
jaapio
force-pushed
the
remove/phpstan-v1-parser
branch
from
1b84cac to
1ec4537
Compare
The classes are part of a testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.