Fix PHPUnit coverage report generation #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also noticed that the information in 
|
Contributor
Author
|
I plan to achieve 100% test coverage today. I think it would be great to do this before releasing the second version to make sure everything really works perfectly. |
Member
|
Nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, the
coversannotations are only needed to speed up the report generation, but the tests are fast enough that there's not much point in using these annotations. Currently, due to their irrelevance, the test coverage report is not generated correctly. I have removed them, and now everything is generated properly.I have also updated the configuration to the new format.
Before
After