Merge pull request #211 from phpmetrics/features/210-check-for-graphviz-when-bubbles-chart-is-generated

installation of graphviz is checked before running analyze (fixes #210)

Author: Halleck45

src/Hal/Application/Config/ConfigFactory.php

@@ -62,6 +62,10 @@ public function factory(InputInterface $input) {
         strlen($input->getOption('offline')) > 0 && $config->getTemplate()->setOffline($input->getOption('offline'));
         strlen($input->getOption('ignore-errors')) > 0 && $config->setIgnoreErrors(true);
 
+        // check for conflicts or missing requirements
+        $validator = new ConfigValidator();
+        $validator->validates($config);
+
         return $config;
 
     }

src/Hal/Application/Config/ConfigValidator.php

@@ -0,0 +1,37 @@
+<?php
+
+/*
+ * (c) Jean-François Lépine <https://twitter.com/Halleck45>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Hal\Application\Config;
+use Hal\Component\Chart\Graphviz;
+use Hal\Component\Config\Hydrator;
+use Hal\Component\Config\Loader;
+use Hal\Component\Config\Validator;
+use Symfony\Component\Console\Input\InputInterface;
+
+/**
+ * Config checker
+ *
+ * @author Jean-François Lépine <https://twitter.com/Halleck45>
+ */
+class ConfigValidator
+{
+    /**
+     * @param Configuration $config
+     */
+    public function validates(Configuration $config)
+    {
+        // graphviz
+        if($config->getLogging()->getChart('bubbles')) {
+            $graphviz = new Graphviz();
+            if(!$graphviz->isAvailable()) {
+                throw new \RuntimeException('Graphviz not installed');
+            }
+        }
+    }
+}

src/Hal/Component/Chart/Graphviz.php

@@ -20,13 +20,11 @@ class Graphviz
     /**
      * Checks installation of graphviz
      *
-     * @throws \RuntimeException
+     * @return boolean
      */
-    public function checkInstallation() {
+    public function isAvailable() {
         $result = shell_exec('circo -V 2>&1');
-        if(!preg_match('!graphviz version!', $result)) {
-            throw new \RuntimeException('Graphviz not installed');
-        }
+        return preg_match('!graphviz version!', $result);
     }
 
     /**
@@ -37,7 +35,9 @@ public function checkInstallation() {
      */
     public function getImage($dotContent) {
 
-        $this->checkInstallation();
+        if(!$this->isAvailable()) {
+            throw new \RuntimeException('Graphviz not installed');
+        }
 
         $dotFile = tempnam(sys_get_temp_dir(), 'phpmetrics-graphviz');
         $imageFile = tempnam(sys_get_temp_dir(), 'phpmetrics-graphviz');