Skip to content

Commit 1be63e5

Browse files
committed
amb
1 parent fb37547 commit 1be63e5

File tree

4 files changed

+79
-81
lines changed

4 files changed

+79
-81
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,4 @@ jobs:
6565
uses: actions/upload-artifact@v2
6666
with:
6767
name: 1.0-SNAPSHOT.jar # Bản build được đánh version 1.0-SNAPSHOT
68-
path: staging
68+
path: staging

.github/workflows/docker-publish.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ jobs:
1212
publish:
1313
name: Publish Auction Backend Docker Image
1414
runs-on: ubuntu-latest
15-
1615
if: ${{ github.event.workflow_run.conclusion == 'success' }}
17-
1816
permissions:
1917
contents: read
2018
packages: write
@@ -32,7 +30,7 @@ jobs:
3230

3331
- name: 'Build project with Maven'
3432
run: |
35-
mvn verify
33+
mvn verify -DskipTests
3634
3735
- name: Get version
3836
id: get_version
@@ -60,4 +58,4 @@ jobs:
6058
run: |
6159
docker build . -t ghcr.io/phuuthanh2003/auction-api:${{ steps.get_version.outputs.version }} -t ghcr.io/phuuthanh2003/auction-api:latest
6260
docker push ghcr.io/phuuthanh2003/auction-api:${{ steps.get_version.outputs.version }}
63-
docker push ghcr.io/phuuthanh2003/auction-api:latest
61+
docker push ghcr.io/phuuthanh2003/auction-api:latest

src/test/java/vn/webapp/backend/auction/BankServiceTest.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,22 @@
1414
class BankServiceTest extends AbstractTestNGSpringContextTests {
1515

1616

17-
// @Autowired
18-
// private BankService bankService;
19-
//
20-
// @Test
21-
// public void testGetAllBankAndReturnsWell() {
22-
// List<Bank> banks = bankService.getAll();
23-
// assertNotNull(banks);
24-
// assertFalse(banks.isEmpty());
25-
// }
26-
//
27-
// @Test
28-
// public void testGetBankByIdAndReturnRightBank() {
29-
// Bank bank = new Bank();
30-
// bank.setId(1);
31-
// Bank foundBank = bankService.getById(bank.getId());
32-
// assertNotNull(foundBank);
33-
// assertEquals(foundBank.getBankName(), "Ngân hàng Nông nghiệp và Phát triển Nông thôn Việt Nam");
34-
// }
17+
@Autowired
18+
private BankService bankService;
19+
20+
@Test
21+
public void testGetAllBankAndReturnsWell() {
22+
List<Bank> banks = bankService.getAll();
23+
assertNotNull(banks);
24+
assertFalse(banks.isEmpty());
25+
}
26+
27+
@Test
28+
public void testGetBankByIdAndReturnRightBank() {
29+
Bank bank = new Bank();
30+
bank.setId(1);
31+
Bank foundBank = bankService.getById(bank.getId());
32+
assertNotNull(foundBank);
33+
assertEquals(foundBank.getBankName(), "Ngân hàng Nông nghiệp và Phát triển Nông thôn Việt Nam");
34+
}
3535
}

src/test/java/vn/webapp/backend/auction/UserServiceTest.java

Lines changed: 58 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -15,64 +15,64 @@
1515
@SpringBootTest
1616
public class UserServiceTest extends AbstractTestNGSpringContextTests {
1717

18-
// @Autowired
19-
// private UserService userService;
20-
//
21-
// @Test
22-
// public void testGetUserByUsernameReturnsWell() {
23-
// // Expected
24-
// String username = "phuuthanh2003";
25-
// // Act
26-
// User user = userService.getUserByUsername(username);
27-
// // Assert
28-
// assertNotNull(user);
29-
// assertEquals(user.getUsername(), username);
30-
// }
31-
//
32-
// @Test
33-
// public void testGetUserByIdReturnsWell() {
34-
// // Expected
35-
// Integer id = 1;
36-
//
37-
// // Act
38-
// User user = userService.getUserById(id);
39-
//
40-
// // Assert
41-
// assertNotNull(user);
42-
// assertEquals(user.getId(), id);
43-
// }
44-
//
45-
// @Test
46-
// public void testGetUserByEmailReturnsWell() {
47-
// // Expected
48-
// String email = "phuuthanh2003@gmail.com";
49-
// // Act
50-
// User user = userService.getUserByEmail(email);
51-
// // Assert
52-
// assertNotNull(user);
53-
// assertEquals(user.getEmail(), email);
54-
// }
55-
//
56-
// @Test
57-
// public void testGetUserByIdReturnsNull() {
58-
// Integer nonExistId = 99;
59-
//
60-
// assertThrows(ResourceNotFoundException.class, () -> userService.getUserById(nonExistId));
61-
// }
62-
//
63-
// @Test
64-
// public void testGetUserByUsernameReturnsNull() {
65-
// String nonExistUsername = "null";
66-
//
67-
// assertThrows(ResourceNotFoundException.class, () -> userService.getUserByUsername(nonExistUsername));
68-
// }
69-
//
70-
// @Test
71-
// public void testGetUserByEmailReturnsNull() {
72-
// String nonExistEmail = "null";
73-
//
74-
// assertThrows(ResourceNotFoundException.class, () -> userService.getUserByEmail(nonExistEmail));
75-
// }
18+
@Autowired
19+
private UserService userService;
20+
21+
@Test
22+
public void testGetUserByUsernameReturnsWell() {
23+
// Expected
24+
String username = "phuuthanh2003";
25+
// Act
26+
User user = userService.getUserByUsername(username);
27+
// Assert
28+
assertNotNull(user);
29+
assertEquals(user.getUsername(), username);
30+
}
31+
32+
@Test
33+
public void testGetUserByIdReturnsWell() {
34+
// Expected
35+
Integer id = 1;
36+
37+
// Act
38+
User user = userService.getUserById(id);
39+
40+
// Assert
41+
assertNotNull(user);
42+
assertEquals(user.getId(), id);
43+
}
44+
45+
@Test
46+
public void testGetUserByEmailReturnsWell() {
47+
// Expected
48+
String email = "phuuthanh2003@gmail.com";
49+
// Act
50+
User user = userService.getUserByEmail(email);
51+
// Assert
52+
assertNotNull(user);
53+
assertEquals(user.getEmail(), email);
54+
}
55+
56+
@Test
57+
public void testGetUserByIdReturnsNull() {
58+
Integer nonExistId = 99;
59+
60+
assertThrows(ResourceNotFoundException.class, () -> userService.getUserById(nonExistId));
61+
}
62+
63+
@Test
64+
public void testGetUserByUsernameReturnsNull() {
65+
String nonExistUsername = "null";
66+
67+
assertThrows(ResourceNotFoundException.class, () -> userService.getUserByUsername(nonExistUsername));
68+
}
69+
70+
@Test
71+
public void testGetUserByEmailReturnsNull() {
72+
String nonExistEmail = "null";
73+
74+
assertThrows(ResourceNotFoundException.class, () -> userService.getUserByEmail(nonExistEmail));
75+
}
7676

7777
}
7878

0 commit comments

Comments
 (0)