Don't display AP disconnect dialog on upgrade

Author: jcapona

frontend/src/components/onboarding_app/App.tsx

@@ -43,6 +43,10 @@ export default () => {
     }
   };
 
+  const pathDisplaysApDisconnectDialog = (path: string) => {
+    return ![PageRoute.Upgrade.toString(), PageRoute.Restart.toString()].includes(path);
+  };
+
   return (
     <>
       <Switch>
@@ -184,7 +188,7 @@ export default () => {
         <Route component={ErrorPage} />
       </Switch>
       <BuildInformation info={buildInfo} className={styles.buildInfo} />
-      <HotspotDisconnectDialog enabled={useLocation().pathname !== PageRoute.Restart && enableDisconnectedFromApDialog} />
+      <HotspotDisconnectDialog enabled={pathDisplaysApDisconnectDialog(useLocation().pathname) && enableDisconnectedFromApDialog} />
     </>
   );
 };

frontend/src/components/onboarding_app/__tests__/App.test.tsx

@@ -354,7 +354,6 @@ describe("App", () => {
 
     // on upgrade page
     await waitForUpgradePage();
-    await checkForDialog();
 
     // mock upgrade and go to registration page
     await upgrade();