Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to track system's light/dark setting in preferences #5

Open
AndrewReaganM opened this issue Mar 20, 2020 · 4 comments
Open

Option to track system's light/dark setting in preferences #5

AndrewReaganM opened this issue Mar 20, 2020 · 4 comments

Comments

@AndrewReaganM
Copy link

Is your feature request related to a problem? Please describe.
Yes. The problem is that on macOS, the settings page has no option to track the system light/dark mode, which makes for a bad experience when using automatic switching between light/dark in macOS.

Describe the solution you'd like
An automatic or "track system" option when selecting between light and dark mode in Settings > General > Theme. Additionally make sure that the system tray icon matches the system light/dark mode setting.

Describe alternatives you've considered
The only alternative solutions to automatic switching are changing the setting twice a day or it not matching the system theme half the day.

Additional context
None.

Thanks!

@SebastianRasch
Copy link

I want to push this request. A year later, the desktop app (now version 2.8.1) still doesn't have an automatic dark mode option, I can only choose dark or light manually. There should definitely be an automatic option, like all other apps also have!

@JonathonH-PIA
Copy link
Contributor

Thanks for the comments Sebastian/Andrew. It looks like a workaround for this is to use the "classic" icons which we allow the system to colorize, since they're grayscale. (We set NSImage.template for those icons.)

I think what we need here are grayscale icons for the default theme too. The default theme currently has the colored dots though, which is why NSImage.template isn't on for those icons.

@SebastianRasch
Copy link

SebastianRasch commented Apr 11, 2021

Hey @JonathonH-PIA, this issue/request is not about the menu bar icon, it's about the theme/appearance for the whole app. You can only choose for the app to be light or dark manually but there is no option to have it change the appearance automatically according to the system setting.

I hope you see the difference. There are two options in the 'General' section of the settings, one for 'Theme' (this is the appearance of the app itself) and one for 'Tray Icon Style' (this is for the menu bar icon only). This request is about the first option 'Theme'. The bug report you mistakenly closed and referred to here was about the other option 'Tray Icon Style'.

@JonathonH-PIA
Copy link
Contributor

Thank you for clarifying @SebastianRasch ! Yeah I see what you mean, this is about the app theme, not the tray icon. I reopened #26 since it is for a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants