Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP FTP Extension #177

Closed
aarongerig opened this issue Nov 25, 2024 · 4 comments
Closed

PHP FTP Extension #177

aarongerig opened this issue Nov 25, 2024 · 4 comments

Comments

@aarongerig
Copy link
Contributor

Was this extension removed intentionally? Before when using pimcore/pimcore:PHP8.2-fpm the FTP extension was enabled, with pimcore/pimcore:php8.3-latest this is no longer the case. If not, would you be open to re-add it?

@brusch
Copy link
Member

brusch commented Nov 28, 2024

@aarongerig actually we only enable extensions that are either required by Pimcore (min flavour) or used by optional features (max flavour). We also have the default as the recommended image.
AFAIK FTP isn't used at all by Pimcore, that's why it's not included, or I'm wrong?

@jdreesen
Copy link
Contributor

Also, it shouldn't be a problem to extend the image and add it yourself, should it?

@aarongerig
Copy link
Contributor Author

@brusch I see – no you're absolutely right, Pimcore does not use FTP and/or XSL in its core. There are some community extensions that require it though and that used to work with the older Pimcore Docker images (e.g. pimcore/pimcore:PHP8.2-fpm) out-of-the-box. That's why I assumed that it was maybe removed unintentionally... 😅

Example XSL: Pimcore Emailizr > Twig Inky Extra > Pinky

But I'm fine with extending the image, as @jdreesen suggested. I'm going to close both issues on that regard.
Thanks for the info!

@jdreesen
Copy link
Contributor

Apparently it was not removed here, but in the official PHP image, see: docker-library/php#1488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants