First of all, thank you for contributing, you are awesome!
Here are a few rules to follow in order to ease code reviews, and discussions before maintainers accept and merge your work.
You MUST follow the PSR-1 and PSR-2. If you don't know about any of them, you should really read the recommendations. Can't wait? Use the PHP-CS-Fixer tool.
You MUST run the test suite.
You MUST write (or update) unit tests.
You SHOULD write documentation.
Please, write commit messages that make sense, and rebase your branch before submitting your Pull Request.
One may ask you to squash your
commits
too. This is used to "clean" your Pull Request before merging it (we don't want
commits such as fix tests, fix 2, fix 3, etc.).
Thank you!
Tests suite uses Docker environments in order to be idempotent to OS's. More than this PHP version is written inside the Dockerfile; this assure to tests the bundle with the same resources. No need to have php or Mongo installed.
You only need Docker set it up.
To allow testing environments more smooth we implemented Makefile You have two commands available:
make testswhich will execute all tests inside the docker.
make test TEST="Tests/Util/FilenameUtilsTest.php"will allow to tests single Test Classes.
There are 3 environments available: PHP 7.2, 7.3 and 7.4-rc. Default environment is PHP 7.3 if you want to execute it against other PHP version please use environment variables as this:
make tests #PHP 7.3 env
TARGET=72 make tests #PHP 7.2 env
TARGET=74 make tests #PHP 7.4 env
make test TEST="Tests/Util/FilenameUtilsTest.php" #PHP 7.3 env
TARGET=72 make test TEST="Tests/Util/FilenameUtilsTest.php" #PHP 7.2 env
TARGET=74 make test TEST="Tests/Util/FilenameUtilsTest.php" #PHP 7.4 env