Skip to content

update mpp_version #19538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 24, 2025
Merged

update mpp_version #19538

merged 6 commits into from
Mar 24, 2025

Conversation

JinheLin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2025
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

windtalker
windtalker approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 14, 2025

@windtalker: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai self-assigned this Jan 14, 2025
@qiancai qiancai added v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. translation/doing This PR’s assignee is translating this PR. labels Jan 14, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 14, 2025
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jan 20, 2025 •
edited
Loading

And also update the default value of storage.format_version in tiflash/tiflash-configuration.md @JinheLin

@JaySon-Huang JaySon-Huang mentioned this pull request Jan 8, 2025
Closed
8 tasks
@JinheLin
Copy link
Contributor Author

And also update the default value of storage.format_version in tiflash/tiflash-configuration.md @JinheLin

@JaySon-Huang Added. PTAL.

JaySon-Huang
JaySon-Huang reviewed Jan 20, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qiancai
qiancai reviewed Jan 26, 2025
View reviewed changes
qiancai
qiancai reviewed Jan 26, 2025
View reviewed changes
@qiancai qiancai mentioned this pull request Feb 12, 2025
Merged
16 tasks
qiancai
qiancai reviewed Feb 13, 2025
View reviewed changes
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 13, 2025
qiancai
qiancai reviewed Feb 13, 2025
View reviewed changes
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 6, 2025

@JinheLin Please rebase this PR to the latest master branch and resolve the conflict with tiflash/tiflash-configuration.md

JinheLin and others added 4 commits March 6, 2025 17:38
@JinheLin
ci
a02c8f0
@JinheLin
ci
c427ab7
@JinheLin
ci
b8d7830
@JinheLin @qiancai
Update system-variables.md
aa84cf3 
Co-authored-by: Grace Cai <qqzczy@126.com>
@JinheLin
Copy link
Contributor Author

JinheLin commented Mar 6, 2025

@JinheLin Please rebase this PR to the latest master branch and resolve the conflict with tiflash/tiflash-configuration.md

Done.

Oreoxmt
Oreoxmt reviewed Mar 10, 2025
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 10, 2025
@JinheLin @Oreoxmt
Update tiflash/tiflash-configuration.md
0eb8b7a 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 24, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-10 07:07:57.26706462 +0000 UTC m=+166832.872593544: ☑️ agreed by Oreoxmt.
  • 2025-03-24 07:40:48.398847977 +0000 UTC m=+859742.083084073: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Mar 24, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit b3404a2 into pingcap:master Mar 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JinheLin @CLAassistant @JaySon-Huang @Oreoxmt @qiancai @windtalker