Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new resource control action SWITCH_GROUP #18926

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add new resource control action SWITCH_GROUP #18926

wants to merge 4 commits into from
+25 −2

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Sep 18, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

Add the newly added SWITCH_GROUP(<name>) syntax document by pingcap/tidb#54804.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)

What is the related PR or file link(s)?

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2024
@hfxsd hfxsd self-assigned this Sep 18, 2024
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.4 This PR/issue applies to TiDB v8.4. and removed missing-translation-status This PR does not have translation status info. labels Sep 18, 2024
@JmPotato
Copy link
Member Author

@nolouch @HuSharp @glorv PTAL

hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

songrijie
songrijie reviewed Sep 18, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
songrijie
songrijie reviewed Sep 18, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
songrijie
songrijie approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato
Add new resource control action SWITCH_GROUP
3858179 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Address the comments
d6adac9 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2024
@hfxsd hfxsd requested a review from lilin90 September 24, 2024 07:27
lilin90
lilin90 reviewed Oct 9, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 07:27:06.080066263 +0000 UTC m=+1550895.820490201: ☑️ agreed by hfxsd.
  • 2024-10-09 09:57:58.855216386 +0000 UTC m=+1040034.275429382: ☑️ agreed by lilin90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songrijie songrijie songrijie approved these changes

@lilin90 lilin90 lilin90 approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@hfxsd hfxsd

Labels
lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JmPotato @songrijie @lilin90 @hfxsd