for MPP request, tiflash doesn't honor FlagIgnoreTruncate

[D3Hunter]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

for MPP request, tiflash doesn't honor FlagIgnoreTruncate, tikv does, see pingcap/tidb#58443 (comment) too

2. What did you expect to see? (Required)

ignore truncate error

3. What did you see instead (Required)

report error

4. What is your TiFlash version? (Required)

8.5

[windtalker]

The root cause is TiFlash's error handle code is out of date after pingcap/tidb#49122, refer to pingcap/tidb#58443 (comment) for more details.

[ti-chi-bot]

@zanmato1984: The label(s) severity/major cannot be applied. These labels are supported: tide/merge-method-rebase, tide/merge-method-squash, tide/merge-method-merge, duplicate, first-time-contributor, good first issue, help wanted, invalid, question, wontfix, make-local-great-again, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.5, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, affects-8.4, affects-8.5, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1, may-affects-8.5.

In response to this:

/label severity/major

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@zanmato1984: The label(s) severity/major cannot be applied. These labels are supported: tide/merge-method-rebase, tide/merge-method-squash, tide/merge-method-merge, duplicate, first-time-contributor, good first issue, help wanted, invalid, question, wontfix, make-local-great-again, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.5, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, affects-8.4, affects-8.5, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1, may-affects-8.5.

In response to this:

/label severity/major

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[zanmato1984]

/severity major

[guo-shaoge]

The problem is when sql_mode is empty(a.k.a. non strict mode), tiflash report overflow error while tikv didn't.

I think it's because import stmt didn't handle sql_mode properly, which has been fixed by tidb/pull/58606.

Although tiflash handle overflow and truncate seperately, but if TiDB can always keep OverflowAsWarning and TruncateAsWarning consistent when dispatching MPPTasks, everything will be ok. Moreover, TiDB already does this.(check code)