Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushdown tidb truncate to tiflash #9846

Closed
guo-shaoge opened this issue Feb 6, 2025 · 0 comments · Fixed by #9842
Closed

pushdown tidb truncate to tiflash #9846

guo-shaoge opened this issue Feb 6, 2025 · 0 comments · Fixed by #9842
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@guo-shaoge
Copy link
Contributor

guo-shaoge commented Feb 6, 2025

Enhancement

For now tiflash truncate use ClickHouse code, the first argument cannot be Decimal(check

//{tipb::ScalarFuncSig::TruncateDecimal, "cast"},
), and the second argument can only be constant(check
if (!scale_column.isColumnConst())
). (which is ok for floor/ceil because they only support one argument, but not ok for truncate, because it support two arguments).

@guo-shaoge guo-shaoge added the type/enhancement The issue or PR belongs to an enhancement. label Feb 6, 2025
@ti-chi-bot ti-chi-bot bot closed this as completed in 4ffbd35 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant