Skip to content

fix(web): consume plans on new-thread implementation#1203

Open
UtkarshUsername wants to merge 1 commit intopingdotgg:mainfrom
UtkarshUsername:fix/consume-plan-on-new-thread-implementation
Open

fix(web): consume plans on new-thread implementation#1203
UtkarshUsername wants to merge 1 commit intopingdotgg:mainfrom
UtkarshUsername:fix/consume-plan-on-new-thread-implementation

Conversation

@UtkarshUsername
Copy link
Contributor

@UtkarshUsername UtkarshUsername commented Mar 19, 2026

Fixes #978
Continues #1133 (see https://pr-navigator.pages.dev/t3code-utkarsh).

What Changed

This extends plan consumption to the Implement in a new thread flow #1133.

PR 1133 introduced the shared plan-consumption plumbing and applied it to same-thread Implement. This PR wires the remaining caller: when the user chooses Implement in a new thread, the new thread’s thread.turn.start command now includes sourceProposedPlan.

That allows the existing orchestration and runtime-ingestion path to mark the source proposed plan as implemented when the new thread’s implementation turn actually starts, so the original plan thread no longer has the "Plan Ready" label.

Why

Before this change, the same-thread implementation flow consumed the plan, but the new-thread implementation flow still started an implementation turn without identifying which source plan it came from.

That left the original thread in a stale "Plan Ready" state even though the plan was already being implemented elsewhere.

This PR keeps the behavior consistent across both implementation entrypoints by reusing the same source-plan mechanism introduced in PR 1133.

UI Changes

Combined the before/after videos and posted it on X because the files' sizes were too large to upload here: https://x.com/UtkarshUsername/status/2033161459447087223?s=20

PR Context

This PR continues on top of:

  • fix/consume-plan-on-same-thread-implementation

See https://pr-navigator.pages.dev/t3code-utkarsh.
image

Made this a different PR because it solves a different pre-existing problem. Actually, I had solved this first, but changed the order to make reviewing easier.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included a video for animation/interaction changes

Note

Include sourceProposedPlan metadata in orchestration dispatch for new-thread flow

When starting a new thread from a proposed plan, the orchestration action payload in ChatView.tsx now includes a sourceProposedPlan object carrying the originating threadId and planId. This ensures the plan is consumed/associated correctly when a thread is created from it.

Macroscope summarized 2617a99.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3407db75-c5c8-4943-bae9-cd06a4ad55ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link planning and implementation threads when using Implement in new thread

2 participants