Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] remove setting in pinpoint-php-aop #543

Closed
Tracked by #542
eeliu opened this issue Oct 25, 2023 · 3 comments
Closed
Tracked by #542

[Feat] remove setting in pinpoint-php-aop #543

eeliu opened this issue Oct 25, 2023 · 3 comments
Assignees
@eeliu
Labels
PHP-AGENT php-aop issue from pinpoint-apm/pinpoint-php-aop.git
Milestone
v0.4.12

Comments

@eeliu
Copy link
Collaborator

eeliu commented Oct 25, 2023 •
edited
Loading

Feature

what's setting.ini ?

like https://github.com/pinpoint-apm/pinpoint-c-agent/blob/dev/plugins/PHP/Framework/Yii2/setting.ini
@eeliu eeliu self-assigned this Oct 25, 2023
@eeliu eeliu mentioned this issue Oct 25, 2023
Closed
1 task
@eeliu eeliu added the php-aop issue from pinpoint-apm/pinpoint-php-aop.git label Oct 26, 2023
@eeliu
Copy link
Collaborator Author

eeliu commented Oct 28, 2023

https://www.php.net/manual/en/book.opcache.php

Call opcache_reset when re-generatatio done, as previous files already cached into opcache.

eeliu added a commit to eeliu/pinpoint-php-aop that referenced this issue Oct 30, 2023
@eeliu
feat(aop): remove setting.ini
234477d 
- refactor aop for addJoinPoint api
- tc for addFunctionAlias/addClassNameAlias

pinpoint-apm/pinpoint-c-agent#543
eeliu added a commit to eeliu/pinpoint-php-aop that referenced this issue Nov 2, 2023
@eeliu
feat(aop): remove setting.ini
eaa33df 
- refactor aop for addJoinPoint api
- tc for addFunctionAlias/addClassNameAlias

pinpoint-apm/pinpoint-c-agent#543
eeliu added a commit to eeliu/pinpoint-php-aop that referenced this issue Nov 3, 2023
@eeliu
feat(aop): remove setting.ini
8656098 
- refactor aop for addJoinPoint api
- tc for addFunctionAlias/addClassNameAlias

pinpoint-apm/pinpoint-c-agent#543
@eeliu eeliu mentioned this issue Nov 3, 2023
Closed
eeliu added a commit to eeliu/pinpoint-php-aop that referenced this issue Nov 3, 2023
@eeliu
feat(aop): remove setting.ini
bce51a6 
- refactor aop for addJoinPoint api
- tc for addFunctionAlias/addClassNameAlias

pinpoint-apm/pinpoint-c-agent#543
@eeliu eeliu mentioned this issue Nov 3, 2023
Merged
eeliu added a commit to pinpoint-apm/pinpoint-php-aop that referenced this issue Nov 3, 2023
@eeliu
feat(aop): remove setting.ini
831cf6c 
- refactor aop for addJoinPoint api
- tc for addFunctionAlias/addClassNameAlias

pinpoint-apm/pinpoint-c-agent#543
@eeliu
Copy link
Collaborator Author

eeliu commented Nov 6, 2023

closed as done

@eeliu eeliu closed this as completed Nov 6, 2023
@eeliu
Copy link
Collaborator Author

eeliu commented Nov 8, 2023

setting.ini support by

https://github.com/pinpoint-apm/pinpoint-php-aop/blob/6c53ce920f778e380975d4d2d562c6d99a06840c/lib/Pinpoint/Plugins/Yii2PerRequestPlugins.php#L75-L84

@eeliu eeliu added this to the v0.4.12 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eeliu eeliu

Labels
PHP-AGENT php-aop issue from pinpoint-apm/pinpoint-php-aop.git
Projects
None yet
Milestone
v0.4.12
Development

No branches or pull requests
1 participant
@eeliu