Implement new Pod Market UI #303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix effective temperature decimal to 2
Add success state after transaction
👷 Deploy request for pintomoney pending review.Visit the deploys page to approve it
|
burr-nim
requested changes
Nov 2, 2025
src/components/ComboInputField.tsx
Outdated
Comment on lines
177
to
188
| baseBalance = tokenAndBalanceMap.get(selectedToken) ?? TokenValue.ZERO; | ||
| } else if (farmerTokenBalance) { | ||
| switch (balanceFrom) { | ||
| case FarmFromMode.EXTERNAL: | ||
| baseBalance = farmerTokenBalance.external || TokenValue.ZERO; | ||
| break; | ||
| case FarmFromMode.INTERNAL: | ||
| baseBalance = farmerTokenBalance.internal || TokenValue.ZERO; | ||
| break; | ||
| default: | ||
| baseBalance = farmerTokenBalance.total || TokenValue.ZERO; | ||
| } |
Contributor
There was a problem hiding this comment.
What does this and the change on lines 210-219 do and why was it necessary?
Author
There was a problem hiding this comment.
Yes. I added this because the buy/fill -> get quote flow was behaving incorrectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the Pod Market pages and components, focusing on enhancing user experience, clarifying navigation, and improving component flexibility. The most significant changes include a refactor of the market route and tab logic, improved balance/allowance handling, and the addition of a reusable smart approval button. There are also UI improvements for market descriptions and a more flexible accordion component.
Market route and tab logic improvements:
mode(buy/sell) andid(create/fill) parameters, ensuring consistent navigation and correct rendering of components likeCreateOrder,FillListing,CreateListing, andFillOrder. This also updates navigation from charts and tables to use query parameters instead of path segments. [1] [2] [3] [4] [5] [6]Balance and allowance handling:
ComboInputFieldto correctly determine the maximum and displayable token amounts, especially when acustomMaxAmountis provided, ensuring that UI reflects the user's true available balance and not just the allowed amount. [1] [2]New reusable components:
SmartApprovalButtoncomponent that automatically determines if token approval is needed (including support for both ERC20 and protocol-specific allowances), manages approval state, and provides user feedback during the approval process.UI/UX improvements:
ReadMoreAccordioncomponent to support aninlinemode, allowing for more flexible placement and styling of expandable content in the UI. [1] [2]