Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5025 #5137 #5139

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Aug 15, 2024

What this PR does / why we need it:
Cherry pick of #5025 #5137.

t-kikuc and others added 2 commits August 15, 2024 15:17
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

Signed-off-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,

docs/main.go's fix is needed

@ffjlabo
Copy link
Member Author

ffjlabo commented Aug 15, 2024

For #5025, this is to fix docs redirect.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v0.48.x@d8d1df0). Learn more about missing BASE report.
Report is 1 commits behind head on release-v0.48.x.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.48.x    #5139   +/-   ##
==================================================
  Coverage                   ?   22.53%           
==================================================
  Files                      ?      519           
  Lines                      ?    56917           
  Branches                   ?        0           
==================================================
  Hits                       ?    12827           
  Misses                     ?    43064           
  Partials                   ?     1026           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ffjlabo ffjlabo merged commit f921374 into release-v0.48.x Aug 15, 2024
26 checks passed
@ffjlabo ffjlabo deleted the cherry-pick-#5025-#5137-to-release-v0.48.x branch August 15, 2024 06:35
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants