Merge pull request #69 from pipeline-tools/v0.22.1

v0.22.1

Author: chriscardillo

gusty/building.py

@@ -145,7 +145,10 @@ def _get_operator_parameters(operator, operator_param_cache):
         operator_param_cache.update({operator: params})
         return params
 
-    params = inspect.signature(operator.__init__).parameters.keys()
+    params = list(inspect.signature(operator.__init__).parameters.keys())
+    template_fields = list(getattr(operator, "template_fields", []))
+    if len(template_fields) > 0:
+        params = list(set(params + template_fields))
     operator_param_cache.update({operator: params})
     return params
 

setup.py

@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name="gusty",
-    version="0.22.0",
+    version="0.22.1",
     author="Chris Cardillo, Michael Chow, David Robinson",
     author_email="cfcardillo23@gmail.com",
     description="Making DAG construction easier",

tests/test_custom_operators.py

@@ -4,6 +4,8 @@
 
 def test_get_operator_parameters():
     class ACustomOperator(BaseOperator):
+        template_fields = ("a_templated_field",)
+
         def __init__(self, a, **kwargs):
             self.a = 1
 
@@ -15,7 +17,7 @@ def execute(self, context):
     params = _get_operator_parameters(ACustomOperator, {})
 
     assert "a" in params
-    assert list(params) == ["self", "a", "kwargs"]
+    assert sorted(params) == ["a", "a_templated_field", "kwargs", "self"]
 
 
 def test_get_operator_parameters_attribute():

tests/test_python_tasks.py

@@ -68,4 +68,4 @@ def test_py_dummy(dag):
 
 def test_automatic_py(dag, py_task):
     task = dag.task_dict["simple_leaf"]
-    assert type(py_task) == type(task)
+    assert type(py_task) is type(task)