Skip to content

Commit 669df8b

Browse files
committed
Fix mismappings #3689
1 parent 0926842 commit 669df8b

File tree

5 files changed

+45
-25
lines changed

5 files changed

+45
-25
lines changed

webextensions/sidebar/styles/base.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@
4040
min-height var(--collapse-animation),
4141
min-width var(--collapse-animation),
4242
opacity var(--collapse-animation),
43-
padding var(--collapse-animation); /* for extra margin on overlay-scrollbar mode */
43+
/* for extra margin on overlay-scrollbar mode */
44+
padding-inline-start var(--collapse-animation),
45+
padding-inline-end var(--collapse-animation);
4446
--tab-animation: var(--tab-basic-animation),
4547
background var(--color-animation),
4648
top var(--collapse-animation);

webextensions/sidebar/styles/photon/base.css

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,9 @@ tab-item,
2222
margin-block-end: -1px;
2323
}
2424

25-
:root:not(.rtl) tab-item.pinned tab-item-substance {
26-
border-width: 0 1px 1px 0;
27-
}
28-
:root.rtl tab-item.pinned tab-item-substance {
29-
border-width: 0 0 1px 1px;
25+
tab-item.pinned tab-item-substance {
26+
border-block-width: 0 1px;
27+
border-inline-width: 0 1px;
3028
}
3129

3230

webextensions/sidebar/styles/proton/proton.css

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -250,15 +250,21 @@ tab-item-substance {
250250
z-index: 100;
251251
}
252252

253-
:root.left tab-item:not(.pinned) tab-item-substance,
254-
:root.left .after-tabs button:not([data-menu-ui]),
255-
:root.left .after-tabs [role="button"]:not([data-menu-ui]) {
253+
:root.left:not(.rtl) tab-item:not(.pinned) tab-item-substance,
254+
:root.left:not(.rtl) .after-tabs button:not([data-menu-ui]),
255+
:root.left:not(.rtl) .after-tabs [role="button"]:not([data-menu-ui]),
256+
:root.right.rtl tab-item:not(.pinned) tab-item-substance,
257+
:root.right.rtl .after-tabs button:not([data-menu-ui]),
258+
:root.right.rtl .after-tabs [role="button"]:not([data-menu-ui]) {
256259
padding-inline-end: 0.35em;
257260
}
258261

259-
:root.right tab-item:not(.pinned) tab-item-substance,
260-
:root.right .after-tabs button:not([data-menu-ui]),
261-
:root.right .after-tabs [role="button"]:not([data-menu-ui]) {
262+
:root.right:not(.rtl) tab-item:not(.pinned) tab-item-substance,
263+
:root.right:not(.rtl) .after-tabs button:not([data-menu-ui]),
264+
:root.right:not(.rtl) .after-tabs [role="button"]:not([data-menu-ui]),
265+
:root.left.rtl tab-item:not(.pinned) tab-item-substance,
266+
:root.left.rtl .after-tabs button:not([data-menu-ui]),
267+
:root.left.rtl .after-tabs [role="button"]:not([data-menu-ui]) {
262268
padding-inline-start: 0.35em;
263269
}
264270

@@ -417,11 +423,13 @@ tab-item:not(.faviconized).subtree-collapsed.all-descendants-highlighted .highli
417423

418424
/* contextual identity marker in tabs */
419425

420-
:root.left tab-item:not(.faviconized) .contextual-identity-marker {
426+
:root.left:not(.rtl) tab-item:not(.faviconized) .contextual-identity-marker,
427+
:root.right.rtl tab-item:not(.faviconized) .contextual-identity-marker {
421428
inset-inline-end: calc(var(--tab-dropshadow-blur) - var(--tab-highlighter-size));
422429
}
423430

424-
:root.right tab-item:not(.faviconized) .contextual-identity-marker {
431+
:root.right:not(.rtl) tab-item:not(.faviconized) .contextual-identity-marker,
432+
:root.left.rtl tab-item:not(.faviconized) .contextual-identity-marker {
425433
inset-inline-start: calc(var(--tab-dropshadow-blur) - var(--tab-highlighter-size));
426434
}
427435

webextensions/sidebar/styles/sidebar/sidebar.css

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* The Original Code is the SidebarStyleTab.
1515
*
1616
* The Initial Developer of the Original Code is YUKI "Piro" Hiroshi.
17-
* Portions created by the Initial Developer are Copyright (C) 2010-2024
17+
* Portions created by the Initial Developer are Copyright (C) 2010-2025
1818
* the Initial Developer. All Rights Reserved.
1919
*
2020
* Contributor(s): Philipp von Weitershausen <philipp@weitershausen.de>
@@ -78,17 +78,21 @@ body,
7878
}
7979

8080
/* Use the splitter to display the border of tab-items */
81-
:root.left {
81+
:root.left:not(.rtl),
82+
:root.right.rtl {
8283
border-inline-end: 1px solid var(--shadow-color);
8384
}
84-
:root:not(.active).left {
85+
:root:not(.active).left:not(.rtl),
86+
:root:not(.active).right.rtl {
8587
border-inline-end-color: var(--shadow-color-inactive);
8688
}
8789

88-
:root.right {
90+
:root.right:not(.rtl),
91+
:root.left.rtl {
8992
border-inline-start: 1px solid var(--shadow-color);
9093
}
91-
:root:not(.active).right {
94+
:root:not(.active).right:not(.rtl),
95+
:root:not(.active).left.rtl {
9296
border-inline-start-color: var(--shadow-color-inactive);
9397
}
9498

webextensions/sidebar/styles/throbber.css

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,22 +106,30 @@ tab-item:not(.collapsed) .throbber {
106106
mask-image: url("./throbber.svg");
107107
}
108108

109-
#tabbar tab-item:not(.collapsed).loading.throbber-unsynchronized:not(.rtl) .throbber::before {
109+
#tabbar tab-item:not(.collapsed).loading.throbber-unsynchronized .throbber::before {
110110
background-image: none;
111+
}
112+
:root:not(.rtl)
113+
#tabbar tab-item:not(.collapsed).loading.throbber-unsynchronized .throbber::before {
111114
mask: -moz-element(#conductor-throbber) no-repeat left center / 100%;
112115
}
113-
#tabbar tab-item:not(.collapsed).loading.throbber-unsynchronized.rtl .throbber::before {
114-
background-image: none;
116+
:root.rtl
117+
#tabbar tab-item:not(.collapsed).loading.throbber-unsynchronized .throbber::before {
115118
mask: -moz-element(#conductor-throbber) no-repeat right center / 100%;
116119
}
117-
:root.simulate-svg-context-fill #tabbar tab-item:not(.collapsed).loading.throbber-unsynchronized .throbber::before {
120+
:root.simulate-svg-context-fill
121+
#tabbar tab-item:not(.collapsed).loading.throbber-unsynchronized .throbber::before {
118122
mask: -moz-element(#conductor-throbber-container) no-repeat;
119123
}
120124

121-
:root#conductor-throbber {
125+
:root:not(.rtl) #conductor-throbber {
122126
background: url("/resources/icons/hourglass.svg") no-repeat left center;
123127
}
124-
:root.animation #conductor-throbber {
128+
:root.rtl #conductor-throbber {
129+
background: url("/resources/icons/hourglass.svg") no-repeat right center;
130+
}
131+
:root.animation:not(.rtl) #conductor-throbber,
132+
:root.animation.rtl #conductor-throbber {
125133
background-image: url("./throbber.svg");
126134
}
127135

0 commit comments

Comments
 (0)