Update the package for Django 3.1+ #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiDelport
suggested changes
Nov 30, 2020
Co-authored-by: Pi Delport <pjdelport@gmail.com>
Co-authored-by: Pi Delport <pjdelport@gmail.com>
Co-authored-by: Pi Delport <pjdelport@gmail.com>
a-olszewski
reviewed
Dec 2, 2020
datatableview/columns.py
Outdated
| @@ -11,7 +11,7 @@ | |||
| import django | |||
| from django.db import models | |||
| from django.db.models import Model, Manager, Q | |||
| from django.db.models.fields import FieldDoesNotExist | |||
| from django.core.exceptions import FieldDoesNotExist | |||
| from django.core.exceptions import ObjectDoesNotExist | |||
There was a problem hiding this comment.
Could be one the same line
from django.core.exceptions import FieldDoesNotExist, ObjectDoesNotExist
|
Totally done! I didn't even see this before I did it - Thanks for the help |
|
Why this was closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve the
ImportErroron Django 3.1 and above, as shown in the issue #244.There is a previous PR with similar changes (#245) but it's not backward compatible with the older Django versions.
Comments and change requests are welcome. I did myself the license of bumping the patch number in the version.