Skip to content

Commit 3ed5997

Browse files
authored
Prevent cli release from mutating previously uploaded artifact (#2088)
Summary: Prevent cli release from mutating previously uploaded artifact The v3 artifacts Action was deprecated and migrated from in #2079. The new API has [breaking changes](https://github.com/actions/upload-artifact/tree/main?tab=readme-ov-file#breaking-changes) including that artifacts are now immutable. During #2079, I missed that the cli release uploads to the same name twice (see grep below) and caused the following [build failure](https://github.com/pixie-io/pixie/actions/runs/12818680277/job/35745089942). Relevant Issues: N/A Type of change: /kind bugfix Test Plan: Verified that the `macos-artifacts` artifact name is no longer used multiple times - [x] Double checked other actions to verify that they aren't trying to mutate an artifact ``` # on main w/o this change (main) $ git grep -A2 upload-artifact | grep name | uniq -c 1 .github/workflows/build_and_test.yaml- name: target_files 1 .github/workflows/cli_release.yaml- name: linux-artifacts 1 .github/workflows/cli_release.yaml- name: artifact-upload-log 2 .github/workflows/cli_release.yaml- name: macos-artifacts <------ the only offender 1 .github/workflows/cli_release.yaml- name: manifest-updates 1 .github/workflows/cloud_release.yaml- name: cloud-artifacts 1 .github/workflows/operator_release.yaml- name: manifest-updates 1 .github/workflows/operator_release.yaml- name: operator-artifacts 1 .github/workflows/operator_release.yaml- name: index-artifacts 1 .github/workflows/perf_common.yaml- name: ${{ hashFiles('run_output') }} 1 .github/workflows/release_update_docs_px_dev.yaml- name: pxl_documentation 1 .github/workflows/update_script_bundle.yaml- name: bundle 1 .github/workflows/vizier_release.yaml- name: manifest-updates 1 .github/workflows/vizier_release.yaml- name: vizier-artifacts 1 .github/workflows/vizier_release.yaml- name: index-artifacts ``` Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent fb9de19 commit 3ed5997

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/cli_release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ jobs:
152152
./ci/cli_upload_signed.sh
153153
- uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
154154
with:
155-
name: macos-artifacts
155+
name: macos-signed-artifacts
156156
path: artifacts/
157157
- uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
158158
with:

0 commit comments

Comments
 (0)