Skip to content

Commit 7a21f5f

Browse files
committed
deps: Bump eslint to v9 + migrate to flat config
Migrated the eslint config using `npx @eslint/migrate-config .eslintrc.json`, and did not work flawlessly, obviously I had to include config to examples into the root config file. Instead, we are able to delete `.eslintrc` that existed for each example directory though `require-atomic-updates` (has been set to `off`) does not exist in the default configs, so removed the line `@typescript-eslint/no-unnecessary-type-assertion` requires a type assertion, removed it for now
1 parent bb924d4 commit 7a21f5f

File tree

11 files changed

+343
-215
lines changed

11 files changed

+343
-215
lines changed

.eslintignore

Lines changed: 0 additions & 7 deletions
This file was deleted.

eslint.config.mjs

Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,90 @@
1+
// @ts-check
2+
3+
import eslint from '@eslint/js';
4+
import tseslint from 'typescript-eslint';
5+
import html from 'eslint-plugin-html';
6+
import { FlatCompat } from '@eslint/eslintrc';
7+
8+
const compat = new FlatCompat({});
9+
10+
export default tseslint.config(
11+
{
12+
files: ['**/*.{js,mjs,ts}'],
13+
ignores: [
14+
'packages/*/docs/',
15+
'packages/*/lib/',
16+
'packages/*/node_modules/',
17+
'packages/*/types/',
18+
19+
'packages/*/examples/**/*.{js,html}',
20+
21+
'**/jest.config.js',
22+
],
23+
extends: [
24+
eslint.configs.recommended,
25+
tseslint.configs.recommended,
26+
],
27+
rules: {
28+
curly: ['error', 'multi-line'],
29+
30+
'no-console': ['error', {
31+
allow: ['info', 'warn', 'error'],
32+
}],
33+
34+
'@typescript-eslint/naming-convention': ['error', {
35+
selector: 'default',
36+
format: ['camelCase'],
37+
}, {
38+
selector: 'variable',
39+
format: ['camelCase', 'UPPER_CASE'],
40+
leadingUnderscore: 'allow',
41+
}, {
42+
selector: 'typeLike',
43+
format: ['PascalCase'],
44+
}, {
45+
selector: 'memberLike',
46+
modifiers: ['public'],
47+
format: ['camelCase', 'UPPER_CASE'],
48+
leadingUnderscore: 'forbid',
49+
}, {
50+
selector: 'memberLike',
51+
modifiers: ['protected'],
52+
format: ['camelCase', 'UPPER_CASE'],
53+
leadingUnderscore: 'require',
54+
}, {
55+
selector: 'memberLike',
56+
modifiers: ['private'],
57+
format: ['camelCase', 'UPPER_CASE'],
58+
leadingUnderscore: 'require',
59+
}, {
60+
selector: 'enumMember',
61+
format: ['PascalCase'],
62+
}, {
63+
selector: 'import',
64+
format: ['camelCase', 'PascalCase', 'UPPER_CASE'],
65+
}],
66+
67+
'@typescript-eslint/no-unused-vars': ['warn', {
68+
args: 'none',
69+
}],
70+
71+
'@typescript-eslint/no-explicit-any': 'off',
72+
'@typescript-eslint/no-non-null-assertion': ['off'],
73+
},
74+
},
75+
76+
{
77+
files: ['packages/*/examples/**/*.{js,html}'],
78+
extends: [
79+
eslint.configs.recommended,
80+
...compat.extends('mdcs'),
81+
],
82+
plugins: {
83+
html,
84+
},
85+
rules: {
86+
'padded-blocks': 'off',
87+
'no-unused-vars': 'off',
88+
},
89+
},
90+
);

package.json

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,20 @@
1919
"prepare": "husky"
2020
},
2121
"devDependencies": {
22+
"@eslint/eslintrc": "^3.2.0",
23+
"@eslint/js": "^9.17.0",
2224
"@gltf-transform/core": "^4.0.8",
2325
"@types/jest": "^29.5.12",
2426
"@types/node": "^22.7.5",
2527
"@typescript-eslint/eslint-plugin": "^7.9.0",
2628
"@typescript-eslint/parser": "^7.9.0",
2729
"cross-env": "^7.0.2",
2830
"esbuild": "^0.24.0",
29-
"eslint": "8",
31+
"eslint": "^9.17.0",
3032
"eslint-config-mdcs": "^5.0.0",
3133
"eslint-config-prettier": "^9.1.0",
32-
"eslint-plugin-html": "^8.1.1",
34+
"eslint-plugin-html": "^8.1.2",
35+
"globals": "^15.14.0",
3336
"husky": "^9.1.5",
3437
"jest": "^29.7.0",
3538
"lerna": "^8.1.8",
@@ -39,7 +42,8 @@
3942
"ts-jest": "^29.1.2",
4043
"ts-node": "^10.9.2",
4144
"typedoc": "^0.26.9",
42-
"typescript": "^5.4.5"
45+
"typescript": "^5.4.5",
46+
"typescript-eslint": "^8.18.2"
4347
},
4448
"name": "three-vrm"
4549
}

packages/three-vrm-animation/examples/.eslintrc

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/three-vrm-core/examples/.eslintrc

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/three-vrm-materials-hdr-emissive-multiplier/examples/.eslintrc

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/three-vrm-materials-mtoon/examples/.eslintrc

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/three-vrm-node-constraint/examples/.eslintrc

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/three-vrm-springbone/examples/.eslintrc

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/three-vrm/examples/.eslintrc

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)