From 987318309d28f5b1c5fccfc0839ec4760e9f46fb Mon Sep 17 00:00:00 2001
From: 0b5vr <0b5vr@0b5vr.com>
Date: Thu, 5 Dec 2024 14:40:45 +0900
Subject: [PATCH] change: Handle SpringBone collider out of index error

Some models put `-1` to the node index of colliders

This also changes an error that occurs when the collider group is not found to a warning
---
 .../src/VRMSpringBoneLoaderPlugin.ts               | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/packages/three-vrm-springbone/src/VRMSpringBoneLoaderPlugin.ts b/packages/three-vrm-springbone/src/VRMSpringBoneLoaderPlugin.ts
index e4c3a3b61..353200dc4 100644
--- a/packages/three-vrm-springbone/src/VRMSpringBoneLoaderPlugin.ts
+++ b/packages/three-vrm-springbone/src/VRMSpringBoneLoaderPlugin.ts
@@ -119,6 +119,15 @@ export class VRMSpringBoneLoaderPlugin implements GLTFLoaderPlugin {
 
     const colliders = extension.colliders?.map((schemaCollider, iCollider) => {
       const node = threeNodes[schemaCollider.node!];
+
+      // Some models put `-1` to the node index of colliders
+      if (node == null) {
+        console.warn(
+          `VRMSpringBoneLoaderPlugin: The collider #${iCollider} attempted to use the node #${schemaCollider.node} but not found`,
+        );
+        return null;
+      }
+
       const schemaShape = schemaCollider.shape!;
 
       // TODO: separate into several functions
@@ -176,13 +185,14 @@ export class VRMSpringBoneLoaderPlugin implements GLTFLoaderPlugin {
 
     const colliderGroups = extension.colliderGroups?.map(
       (schemaColliderGroup, iColliderGroup): VRMSpringBoneColliderGroup => {
-        const cols = (schemaColliderGroup.colliders ?? []).map((iCollider) => {
+        const cols = (schemaColliderGroup.colliders ?? []).flatMap((iCollider) => {
           const col = colliders?.[iCollider];
 
           if (col == null) {
-            throw new Error(
+            console.warn(
               `VRMSpringBoneLoaderPlugin: The colliderGroup #${iColliderGroup} attempted to use a collider #${iCollider} but not found`,
             );
+            return [];
           }
 
           return col;