-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat #7] 메뉴 도메인 구현 #8
Open
squareCaaat
wants to merge
41
commits into
main
Choose a base branch
from
feat/#7/menu_model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 내용
엔티티
Map<String, Integer>
양식으로 하였습니다.calculateByReview
를 통해 평점과 각 속성들의 수치를 계산합니다.@CreatedDate
,@LastModifiedDate
사용해 작성일/수정일을 자동으로 관리합니다.컨트롤러
Map<String, Integer>
형식입니다.서비스 구현체
유의 사항
📝 제가 짠 코드에서 Member는 모두 Controller 단에서는
@AuthenticationPrincipal
을 활용해 socialId로 Member를 찾습니다.📝 서비스와 레포지토리에서도 long socialId로 Member를 찾도록 하였습니다.
📝 QueryDSL 을 처음 사용해봐서 효율적인 쿼리가 아닐 수 있습니다. 😢
❗이때 socialId는 기존의 String 타입에서 Long 타입으로 변경되었습니다. 이 부분은 추후 제 코드를 참고해 수정하셔도 좋습니다!
❌ 이미지 관련 로직은 아직 구현하지 못하였습니다.
❌ Member와 다른 엔티티 간의 관계를 설정하지 않았습니다.
🙏 요청 사항
Redis 환경이 처음이고 카카오API 서비스가 비즈앱으로 전환이 안되서 이메일을 받아 올 수 없어서 구현한 로직을 테스트해주실 수 있나요?
이미지 처리 관련 로직이 없어서 어떻게 처리해야할지 모르겠어요.