From 2f0a3473ed1cb79927b5625bd852b02d79ed5d6f Mon Sep 17 00:00:00 2001 From: Hafsa-Naeem Date: Fri, 19 Dec 2025 15:43:24 +0500 Subject: [PATCH 1/2] pkp/pkp-lib#10962 Add migration mapping for pressAcronym to contextAcronym --- classes/emailTemplate/DAO.php | 8 +++++--- .../mail/variables/ContextEmailVariable.php | 20 ------------------- .../upgrade/v3_4_0/InstallEmailTemplates.php | 6 +----- dbscripts/xml/upgrade.xml | 2 ++ 4 files changed, 8 insertions(+), 28 deletions(-) diff --git a/classes/emailTemplate/DAO.php b/classes/emailTemplate/DAO.php index 3e2fca2e1c9..e942fc2d5c0 100644 --- a/classes/emailTemplate/DAO.php +++ b/classes/emailTemplate/DAO.php @@ -1,4 +1,5 @@ 'pressName', - 'contextUrl' => 'pressUrl', - 'contextSignature' => 'pressSignature', + 'pressName' => 'contextName', + 'pressUrl' => 'contextUrl', + 'pressSignature' => 'contextSignature', + 'pressAcronym' => 'contextAcronym' ]; } } diff --git a/classes/mail/variables/ContextEmailVariable.php b/classes/mail/variables/ContextEmailVariable.php index d7e80011d1a..97ca41244de 100644 --- a/classes/mail/variables/ContextEmailVariable.php +++ b/classes/mail/variables/ContextEmailVariable.php @@ -20,24 +20,6 @@ class ContextEmailVariable extends PKPContextEmailVariable { - public const CONTEXT_NAME = 'pressName'; - public const CONTEXT_URL = 'pressUrl'; - public const CONTEXT_SIGNATURE = 'pressSignature'; - public const CONTEXT_ACRONYM = 'contextAcronym'; - - /** - * @copydoc Variable::descriptions() - */ - public static function descriptions(): array - { - return array_merge( - parent::descriptions(), - [ - static::CONTEXT_ACRONYM => __('emailTemplate.variable.context.contextAcronym'), - ] - ); - } - /** * @copydoc Variable::values() */ @@ -48,8 +30,6 @@ public function values(string $locale): array // Pass the values into the context signature so variables // used in the signature can be rendered. $values[static::CONTEXT_SIGNATURE] = $this->getContextSignature($values); - $values[static::CONTEXT_ACRONYM] = htmlspecialchars($this->context->getLocalizedData('acronym')); - return $values; } } diff --git a/classes/migration/upgrade/v3_4_0/InstallEmailTemplates.php b/classes/migration/upgrade/v3_4_0/InstallEmailTemplates.php index 7c4ac7a89e4..c124f0b0caa 100644 --- a/classes/migration/upgrade/v3_4_0/InstallEmailTemplates.php +++ b/classes/migration/upgrade/v3_4_0/InstallEmailTemplates.php @@ -47,10 +47,6 @@ protected function getEmailTemplateKeys(): array protected function getAppVariableNames(): array { - return [ - 'contextName' => 'pressName', - 'contextUrl' => 'pressUrl', - 'contextSignature' => 'pressSignature', - ]; + return []; } } diff --git a/dbscripts/xml/upgrade.xml b/dbscripts/xml/upgrade.xml index dceb916e9c0..5847505cab4 100644 --- a/dbscripts/xml/upgrade.xml +++ b/dbscripts/xml/upgrade.xml @@ -163,6 +163,7 @@ + @@ -200,6 +201,7 @@ + From cca71351087f56efdf5880dfee19136ae288a230 Mon Sep 17 00:00:00 2001 From: Hafsa-Naeem Date: Fri, 19 Dec 2025 23:05:24 +0500 Subject: [PATCH 2/2] pkp/pkp-lib#10962 Submodule update ##Hafsa-Naeem/i10962-main-fix --- lib/pkp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pkp b/lib/pkp index 638f0ad3b89..834bada444f 160000 --- a/lib/pkp +++ b/lib/pkp @@ -1 +1 @@ -Subproject commit 638f0ad3b89be36bd5e8d698f58f58b873dec9ff +Subproject commit 834bada444f5d6386075b1844107d0093c75974b