Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COUNTER R5 form field customer_id is not provided correctly to the API endpoint #10350

Closed
bozana opened this issue Aug 29, 2024 · 2 comments
Closed

COUNTER R5 form field customer_id is not provided correctly to the API endpoint #10350

bozana opened this issue Aug 29, 2024 · 2 comments
Assignees
@bozana
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.4.0-8

Comments

@bozana
Copy link
Collaborator

bozana commented Aug 29, 2024 •
edited
Loading

The way the COUNTER R5 form field customer_id is checked here https://github.com/pkp/ui-library/blob/stable-3_4_0/src/components/Form/counter/CounterReportForm.vue#L39 is wrong:
When an institution is selected having an integer number > 0 as value the condition https://github.com/pkp/ui-library/blob/stable-3_4_0/src/components/Form/counter/CounterReportForm.vue#L44 is not passed.

S. also this forum post: https://forum.pkp.sfu.ca/t/counter-r5-report-generator-doesnt-work/90206.

Because we still work on porting the functionality to the main, this changes for main will be considered in this issue: #9666

PR:
pkp/ui-library#404

only submodule updates:
@bozana bozana added this to the 3.4.0-8 milestone Aug 29, 2024
@bozana bozana self-assigned this Aug 29, 2024
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Aug 29, 2024
bozana added a commit to bozana/ui-library that referenced this issue Aug 29, 2024
@bozana
pkp/pkp-lib#10350 fix the check of the COUNTER R5 form field customer_id
02ad1c8
@bozana bozana mentioned this issue Aug 29, 2024
Merged
@bozana
Copy link
Collaborator Author

bozana commented Aug 29, 2024 •
edited
Loading

@jardakotesovec and @blesildaramirez, could you please review the PRs above? Thanks a lot!

bozana added a commit to bozana/ojs that referenced this issue Aug 29, 2024
@bozana
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
d5441e7
@bozana bozana mentioned this issue Aug 29, 2024
Merged
bozana added a commit to bozana/omp that referenced this issue Aug 29, 2024
@bozana
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
1b5bd4f
bozana added a commit to bozana/ops that referenced this issue Aug 29, 2024
@bozana
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
449deea
This was referenced Aug 29, 2024
Merged
Merged
bozana added a commit to bozana/ui-library that referenced this issue Aug 29, 2024
@bozana
pkp/pkp-lib#10350 fix the check of the COUNTER R5 form field customer_id
284dd2c
@bozana bozana mentioned this issue Aug 30, 2024
Open
@bozana
Copy link
Collaborator Author

bozana commented Sep 6, 2024

Hi @jardakotesovec and @blesildaramirez, could you please review (and approve) this PR -- it would be good if the bug fix would make it into the next release :-)

bozana added a commit to bozana/ojs that referenced this issue Sep 6, 2024
@bozana
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
65be82b
bozana added a commit to bozana/omp that referenced this issue Sep 6, 2024
@bozana
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
61c3dc9
bozana added a commit to bozana/ops that referenced this issue Sep 6, 2024
@bozana
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
83881aa
bozana added a commit to pkp/ui-library that referenced this issue Sep 6, 2024
@bozana
Merge pull request #404 from bozana/10350
b4ccfa0 
pkp/pkp-lib#10350 fix the check of the COUNTER R5 form field customer_id
bozana added a commit to pkp/ojs that referenced this issue Sep 6, 2024
@bozana
Merge pull request #4416 from bozana/10350
6aba5f0 
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
bozana added a commit to pkp/omp that referenced this issue Sep 6, 2024
@bozana
Merge pull request #1683 from bozana/10350
1f8e5e0 
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
bozana added a commit to pkp/ops that referenced this issue Sep 6, 2024
@bozana
Merge pull request #756 from bozana/10350
c0e4e60 
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
@bozana bozana closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
Statistics
Status: Done
Milestone
3.4.0-8
Development

No branches or pull requests
1 participant
@bozana