Missing locale key site.upgradeAvailable.admin in OMP

[NateWr]

Describe the bug
The locale key, site.upgradeAvailable.admin, is not present in OMP. This leads to a missing message in the site administration area.

To Reproduce
I'm not sure of the reproduction steps, but I the message is shown when VersionCheck::checkIfNewVersionExists() returns true.

1. Login as admin
2. Go to Administration area
3. See error

What application are you using?
OMP main branch running a stable-3_4_0 database.

Additional information

[kaitlinnewson]

This looks like a case of just needing to move the locale key to pkp-lib from OJS, but it's not easy to reproduce because show_upgrade_warning is not typically set in the OMP config file/template (see also #8543).

[kaitlinnewson]

PRs for review @asmecher:

• OMP 3_3_0: pkp/pkp-lib#9294 add site upgrade locale keys to OMP omp#1675
• OMP 3_4_0: pkp/pkp-lib#9294 add site upgrade locale keys to OMP omp#1680
• OMP main: pkp/pkp-lib#9294 add site upgrade locale keys to OMP omp#1681

[asmecher]

@kaitlinnewson, unfortunately the locale key makes explicit reference to OJS, and would need to be generalized in order to be moved to the pkp-lib shared library.

[kaitlinnewson]

@kaitlinnewson, unfortunately the locale key makes explicit reference to OJS, and would need to be generalized in order to be moved to the pkp-lib shared library.

🤦‍♀️ Not sure how I missed that! I'll work on generalizing this key.

[kaitlinnewson]

@asmecher I've updated the list of PRs above, ready for another review. Since we are not actively translating the 3.3 branch, I've copied over the full text from OJS and updated the strings to OMP where possible.

For 3.4/main, I made a small change to the english text so we aren't using "here" links to follow better accessibility practices.

[asmecher]

Thanks, @kaitlinnewson, looks good! Were those stable-3_3_0 translations adapted manually from OJS translations, or machine translated, or something else? Generally speaking, it's good to mark them fuzzy so anyone working with translation tools can give them a review.

[asmecher]

⬆️ Sorry, I see you specified that these were adapted manually. Should be good to go!

[asmecher]

All merged, thanks!