Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large file problems: uint32_t typo #3

Open
throwaway-zz opened this issue Nov 1, 2010 · 1 comment
Open

large file problems: uint32_t typo #3

throwaway-zz opened this issue Nov 1, 2010 · 1 comment

Comments

@throwaway-zz
Copy link

There's an embarrassing typo in includes/dmg/dmg.h that prevents libdmg from reading large dmgs: the return value of readUInt64 should be uint64_t, not uint32_t.

A more cosmetic issue is that there's a line in hfs/hfslib.c that prints the total filesystem size, and it has some 32-bit values that need to be cast to 64-bit before multiplying.

After fixing those issues, libdmg seems to work fine at listing and extracting files from a 7 GB dmg.

@nopara73
Copy link

There's something going on here regarding this issue. Not sure I fully understand though:
http://www.nathancoulson.com/proj_cross_tools.php
http://www.nathancoulson.com/proj/cross/libdmg-hfsplus-fixes-1.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants