Skip to content

Commit 628bba8

Browse files
authored
Add missing logging for other query paths (#18)
1 parent 53fac19 commit 628bba8

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

handler.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ func (h *handler) ComQuery(c *mysql.Conn, query string, callback func(*sqltypes.
126126
slog.String("addr", c.GetRawConn().LocalAddr().String()),
127127
slog.Int("mysql_id", int(c.ConnectionID)),
128128
slog.String("query", query),
129+
slog.Bool("olap", data.IsOLAP()),
129130
)
130131

131132
if data.IsOLAP() {
@@ -157,6 +158,15 @@ func (h *handler) ComQuery(c *mysql.Conn, query string, callback func(*sqltypes.
157158
func (h *handler) ComPrepare(c *mysql.Conn, query string, bindVars map[string]*vitessquerypb.BindVariable) ([]*vitessquerypb.Field, error) {
158159
data := h.clientData(c)
159160

161+
defer h.logger.LogAttrs(
162+
context.Background(),
163+
slog.LevelDebug,
164+
"prepare",
165+
slog.String("addr", c.GetRawConn().LocalAddr().String()),
166+
slog.Int("mysql_id", int(c.ConnectionID)),
167+
slog.String("query", query),
168+
)
169+
160170
resp, err := h.client.Prepare(context.Background(), connect.NewRequest(&psdbpb.PrepareRequest{
161171
Session: data.Session,
162172
Query: query,
@@ -180,6 +190,16 @@ func (h *handler) ComPrepare(c *mysql.Conn, query string, bindVars map[string]*v
180190
func (h *handler) ComStmtExecute(c *mysql.Conn, prepare *mysql.PrepareData, callback func(*sqltypes.Result) error) error {
181191
data := h.clientData(c)
182192

193+
defer h.logger.LogAttrs(
194+
context.Background(),
195+
slog.LevelDebug,
196+
"stmt_execute",
197+
slog.String("addr", c.GetRawConn().LocalAddr().String()),
198+
slog.Int("mysql_id", int(c.ConnectionID)),
199+
slog.String("query", prepare.PrepareStmt),
200+
slog.Bool("olap", data.IsOLAP()),
201+
)
202+
183203
if data.IsOLAP() {
184204
return h.streamExecute(c, data, prepare.PrepareStmt, castBindVars(prepare.BindVars), callback)
185205
}

0 commit comments

Comments
 (0)