Skip to content

Commit 45edbb1

Browse files
Self-review
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
1 parent 22fade6 commit 45edbb1

File tree

5 files changed

+18
-9
lines changed

5 files changed

+18
-9
lines changed

go/vt/proto/binlogdata/binlogdata.pb.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/vt/proto/vtgate/vtgate.pb.go

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/vt/vttablet/tabletserver/vstreamer/vstreamer.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,14 @@ func (vs *vstreamer) buildSidecarTablePlan(id uint64, tm *mysql.TableMap) ([]*bi
684684
tableName := tm.Name
685685
switch tableName {
686686
case "resharding_journal":
687+
// A journal is a special case that generates a JOURNAL event.
687688
case "schema_version":
689+
// Generates a Version event when it detects that a schema is stored in the schema_version table.
690+
691+
// SkipMetaCheck is set during PITR restore: some table metadata is not fetched in that case.
692+
if vs.se.SkipMetaCheck {
693+
return nil, nil
694+
}
688695
default:
689696
if vs.options == nil {
690697
return nil, nil

proto/binlogdata.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ message RowEvent {
344344
string keyspace = 3;
345345
string shard = 4;
346346
uint32 flags = 5; // https://dev.mysql.com/doc/dev/mysql-server/latest/classbinary__log_1_1Rows__event.html
347-
bool is_internal = 6;
347+
bool is_internal = 6; // set for sidecardb tables
348348
}
349349

350350
// FieldEvent represents the field info for a table.
@@ -361,7 +361,7 @@ message FieldEvent {
361361
// NOTE: because this is the use case, this is ONLY ever set today in
362362
// vstreams managed by the vstreamManager.
363363
bool enum_set_string_values = 25;
364-
bool is_internal = 26;
364+
bool is_internal = 26; // set for sidecardb tables
365365
}
366366

367367
// ShardGtid contains the GTID position for one shard.

proto/vtgate.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,7 @@ message VStreamFlags {
302302
string cells = 4;
303303
string cell_preference = 5;
304304
string tablet_order = 6;
305+
// When set, all new row events from the `heartbeat` table, in all shards, in the sidecardb will be streamed.
305306
bool stream_keyspace_heartbeats = 7;
306307
}
307308

0 commit comments

Comments
 (0)